Skip to content

fix(backend): canonicalize symlink target before installs check #7671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 2 commits into from
Jan 14, 2026
Merged

fix(backend): canonicalize symlink target before installs check #7671

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d32e4b2
fix(backend): canonicalize symlink target before installs check
jdx Jan 14, 2026
a567b79
fix(backend): handle non-existent symlink targets and asymmetric cano…
jdx Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/backend/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,16 @@ pub trait Backend: Debug + Send + Sync {
} else {
path.parent().unwrap_or(&path).join(&target)
};
if target.starts_with(*dirs::INSTALLS) {
// Canonicalize to resolve any ".." components before checking.
// If target doesn't exist (canonicalize fails), don't skip - treat as needing install
let Ok(target) = target.canonicalize() else {
return None;
};
// Canonicalize INSTALLS too for consistent comparison (handles symlinked data dirs)
let installs = dirs::INSTALLS
.canonicalize()
.unwrap_or(dirs::INSTALLS.to_path_buf());
if target.starts_with(installs) {
return Some(path);
}
}
Expand Down
Loading