Skip to content

feat: Move iTerm to OSC9;4 supported terminals #7485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 3 commits into from
Dec 30, 2025
Merged

feat: Move iTerm to OSC9;4 supported terminals #7485

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dffb81e
Move iTerm to OSC9;4 supported terminals
Maks3w Dec 26, 2025
71780b2
Update settings.toml
Maks3w Dec 26, 2025
7454c01
Merge branch 'main' into iterm2
Maks3w Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion settings.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1175,7 +1175,7 @@ tool installations. The progress bar appears in the terminal's window UI, separa
from the text output.

mise automatically detects whether your terminal supports OSC 9;4 and will only send
these sequences if supported. Terminals like Alacritty, iTerm2, WezTerm, and kitty
these sequences if supported. Terminals like Alacritty, WezTerm, and kitty
do not support OSC 9;4 and will not receive these sequences.

Set to false to disable this feature if you prefer not to see these indicators.
Expand Down
2 changes: 1 addition & 1 deletion src/ui/osc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ fn terminal_supports_osc_9_4() -> bool {
match term_program.as_str() {
// Supported terminals
"ghostty" => return true,
"iTerm.app" => return true,
"vscode" => return true,
// Unsupported terminals
"iTerm.app" => return false, // iTerm2 uses OSC 9 for notifications, not OSC 9;4
"WezTerm" => return false,
Comment on lines +47 to 50

Copilot AI Dec 26, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of supported terminals should be alphabetically sorted for better maintainability. Consider reordering the entries so 'iTerm.app' comes before 'ghostty' or after 'vscode' depending on the sorting approach (case-sensitive or case-insensitive).

Copilot uses AI. Check for mistakes.
"Alacritty" => return false,
_ => {}
Expand Down
Loading