feat: Move iTerm to OSC9;4 supported terminals#7485
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates iTerm2's classification in the OSC 9;4 terminal support detection logic following the release of iTerm2 v3.6.6 on November 17, 2025, which added support for OSC 9;4 progress bars.
Key changes:
- Moved iTerm2 from unsupported to supported terminals for OSC 9;4 sequences
- Updated documentation to reflect iTerm2's new capability
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ui/osc.rs | Moved iTerm.app detection from unsupported to supported terminals list |
| settings.toml | Removed iTerm2 from the list of terminals that don't support OSC 9;4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "iTerm.app" => return true, | ||
| "vscode" => return true, | ||
| // Unsupported terminals | ||
| "iTerm.app" => return false, // iTerm2 uses OSC 9 for notifications, not OSC 9;4 | ||
| "WezTerm" => return false, |
There was a problem hiding this comment.
The list of supported terminals should be alphabetically sorted for better maintainability. Consider reordering the entries so 'iTerm.app' comes before 'ghostty' or after 'vscode' depending on the sorting approach (case-sensitive or case-insensitive).
|
The failing CI should pass now, please update this branch. |
|
done |
On Nov 17th iTerm has released v3.6.6 with OSC 9;4 support