Skip to content

feat: Move iTerm to OSC9;4 supported terminals#7485

Merged
jdx merged 3 commits into
jdx:mainfrom
Maks3w:iterm2
Dec 30, 2025
Merged

feat: Move iTerm to OSC9;4 supported terminals#7485
jdx merged 3 commits into
jdx:mainfrom
Maks3w:iterm2

Conversation

@Maks3w
Copy link
Copy Markdown
Contributor

@Maks3w Maks3w commented Dec 26, 2025

On Nov 17th iTerm has released v3.6.6 with OSC 9;4 support

iTerm2 version 3.6.6 was released on
November 17, 2025.

New Features:
- Added setting to show per-pane title bars when
  there is only one pane.
- If the previous release left you with red tabs
  in a tmux window, this one will offer to fix
  them.
- Add KeePassXC integration in password manager.
- There's a new key binding action to toggle a
  checkbox of your choosing in settings.
- Add support for OSC 9;4 progress bars.
- Add support for DECDSR 997 and DECSET/DECRESET
  2031 for dark mode reporting.
- Cursor animation can now be enabled always.
  Previously it only happened in interactive apps.
https://iterm2.com/downloads.html

Copilot AI review requested due to automatic review settings December 26, 2025 09:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates iTerm2's classification in the OSC 9;4 terminal support detection logic following the release of iTerm2 v3.6.6 on November 17, 2025, which added support for OSC 9;4 progress bars.

Key changes:

  • Moved iTerm2 from unsupported to supported terminals for OSC 9;4 sequences
  • Updated documentation to reflect iTerm2's new capability

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/ui/osc.rs Moved iTerm.app detection from unsupported to supported terminals list
settings.toml Removed iTerm2 from the list of terminals that don't support OSC 9;4

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ui/osc.rs
Comment on lines +47 to 50
"iTerm.app" => return true,
"vscode" => return true,
// Unsupported terminals
"iTerm.app" => return false, // iTerm2 uses OSC 9 for notifications, not OSC 9;4
"WezTerm" => return false,
Copy link

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of supported terminals should be alphabetically sorted for better maintainability. Consider reordering the entries so 'iTerm.app' comes before 'ghostty' or after 'vscode' depending on the sorting approach (case-sensitive or case-insensitive).

Copilot uses AI. Check for mistakes.
@Maks3w Maks3w changed the title Move iTerm to OSC9;4 supported terminals feat: Move iTerm to OSC9;4 supported terminals Dec 26, 2025
@risu729
Copy link
Copy Markdown
Contributor

risu729 commented Dec 29, 2025

The failing CI should pass now, please update this branch.

@Maks3w
Copy link
Copy Markdown
Contributor Author

Maks3w commented Dec 30, 2025

done

@jdx jdx merged commit 64a9b8c into jdx:main Dec 30, 2025
33 checks passed
@Maks3w Maks3w deleted the iterm2 branch December 30, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants