Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/cli/test_ls_cache
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ export MISE_USE_VERSIONS_HOST=1
# verify that cache is reused for `mise ls`
# see https://github.com/jdx/mise/discussions/6736

assert_contains "mise -v use bat 2>&1" "GET https://mise-versions.jdx.dev/bat.toml 200 OK"
assert_contains "mise -v use bat 2>&1" "GET https://mise-versions.jdx.dev/tools/bat.toml 200 OK"
touch -t 202001010000 "$MISE_CACHE_DIR/bat/"*
assert_not_contains "mise -v ls bat 2>&1" "GET https://mise-versions.jdx.dev/bat.toml 200 OK"
assert_not_contains "mise -v ls bat 2>&1" "GET https://mise-versions.jdx.dev/tools/bat.toml 200 OK"
2 changes: 1 addition & 1 deletion src/plugins/core/python.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ impl PythonPlugin {
let settings = Settings::get();
let url_path = python_precompiled_url_path(&settings);
let rsp = HTTP_FETCH
.get_bytes(format!("https://mise-versions.jdx.dev/{url_path}"))
.get_bytes(format!("https://mise-versions.jdx.dev/tools/{url_path}"))
.await?;
let mut decoder = GzDecoder::new(rsp.as_ref());
let mut raw = String::new();
Expand Down
4 changes: 2 additions & 2 deletions src/versions_host.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ pub async fn list_versions(tool: &str) -> eyre::Result<Option<Vec<VersionInfo>>>
}

// Use TOML format which includes created_at timestamps
let url = format!("https://mise-versions.jdx.dev/{}.toml", tool);
let url = format!("https://mise-versions.jdx.dev/tools/{}.toml", tool);
let versions: Vec<VersionInfo> = match HTTP_FETCH.get_text(&url).await {
Ok(body) => {
let response: VersionsResponse = toml::from_str(&body)?;
Expand Down Expand Up @@ -139,7 +139,7 @@ pub fn track_install(tool: &str, full: &str, version: &str) {
async fn track_install_async(tool: &str, full: &str, version: &str) -> eyre::Result<()> {
use crate::cli::version::{ARCH, OS};

let url = "https://mise-tools.jdx.dev/api/track";
let url = "https://mise-versions.jdx.dev/api/track";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Install tracking endpoint host likely wrong

track_install_async changes the tracking URL from mise-tools.jdx.dev/api/track to mise-versions.jdx.dev/api/track, which is unrelated to the /tools/ path update and may point at a host that doesn’t serve the tracking API. This can silently break install tracking when use_versions_host_track is enabled.

Fix in Cursor Fix in Web

let body = serde_json::json!({
"tool": tool,
Expand Down
Loading