test(vfox): replace flaky external HTTP tests with local mock server by jdx · Pull Request #6354 · jdx/mise

jdx · 2025-09-20T23:21:27Z

Summary

Fixes flaky vfox HTTP tests by replacing external service dependencies with a local mock server and improving test isolation.

Changes

1. Replaced external HTTP tests with local mock server

Removed dependency on unreliable external services (httpbin.org)
Tests now use a local mock server for deterministic behavior
Faster test execution and no network dependencies

2. Fixed cross-platform compatibility

Replaced hardcoded /tmp paths with std::env::temp_dir()
Works correctly on Windows and other platforms

3. Improved test isolation

Switched from shared temp directories to isolated tempfile::TempDir instances
Prevents race conditions when tests run concurrently
Automatic cleanup when tests complete

4. Enhanced code readability

Refactored tests to use mlua::chunk! macro with variable injection
Cleaner, more maintainable test code with better IDE support

5. Resolved security advisory

Replaced httpmock with wiremock to fix RUSTSEC-2025-0052
Removed dependency on discontinued async-std crate

Testing

All tests passing locally
Tests can run safely in parallel without interference
No external network dependencies

Fixes flaky test issue seen in: https://github.com/jdx/mise/actions/runs/17885055691/job/50857630121?pr=6352

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Copilot

Pull Request Overview

This PR replaces flaky external HTTP tests with a local mock server to improve test reliability and speed. The tests were previously dependent on external services like httpbin.org which could cause intermittent failures in CI environments.

Replaced external HTTP calls with httpmock library for controlled testing
Removed #[ignore] annotation from previously flaky download test
Added necessary build dependencies for cross-compilation support

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
crates/vfox/Cargo.toml	Added httpmock dev dependency for test mocking
crates/vfox/src/lua_mod/http.rs	Replaced external HTTP calls with local mock server endpoints
src/backend/aqua.rs	Simplified GitHub token retrieval using env module
packaging/dev/Dockerfile	Added clang and libclang-dev for build requirements
.github/workflows/test-plugins.yml	Added cross tool installation for CI
.devcontainer/devcontainer.json	Added MISE_TRUSTED_CONFIG_PATHS environment variable
.devcontainer/post-create.sh	Added mise install command to post-create script

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-20T23:21:59Z

crates/vfox/src/lua_mod/http.rs

-        let path = "test/data/test_download_file.txt";
-        lua.load(mlua::chunk! {
+
+        let path = "/tmp/vfox_test_download_file.txt";


Using hardcoded /tmp/ path may fail on Windows systems. Consider using std::env::temp_dir() or tempfile::tempdir() for cross-platform compatibility.

Copilot · 2025-09-20T23:21:59Z

crates/vfox/src/lua_mod/http.rs

+        lua.load(format!(
+            r#"
            local http = require("http")
-            local resp = http.get({ url = "https://httpbin.org/get" })
+            local resp = http.get({{ url = "{}" }})
            assert(resp.status_code == 200)
            assert(type(resp.body) == "string")
-        })
+        "#,
+            url
+        ))


[nitpick] Using string formatting for Lua code makes it harder to read and maintain. Consider using mlua::chunk! macro with variable injection for better readability and IDE support.

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-20T23:33:52Z

crates/vfox/src/lua_mod/file.rs

+        let temp_dir = std::env::temp_dir();
+        let filepath = temp_dir.join("vfox-lua-file-read");
+        let filepath_str = filepath.to_string_lossy().to_string();
+        fs::write(&filepath, "hello world").unwrap();


Using a fixed filename in the shared system temp directory can cause race conditions or flaky failures if tests run concurrently (e.g. parallel cargo test or multiple processes). Prefer generating a unique temp file (e.g. with tempfile::NamedTempFile) to isolate the test. Example: let file = tempfile::NamedTempFile::new().unwrap(); let filepath_str = file.path().to_string_lossy().to_string(); then write via std::fs::write(file.path(), "hello world") and use filepath_str in the Lua chunk.

Copilot · 2025-09-20T23:33:53Z

crates/vfox/src/lua_mod/file.rs

+        let temp_dir = std::env::temp_dir();
+        let src_path = temp_dir.join("test_symlink_src");
+        let dst_path = temp_dir.join("test_symlink_dst");
+        let src_path_str = src_path.to_string_lossy().to_string();
+        let dst_path_str = dst_path.to_string_lossy().to_string();
+        let _ = fs::remove_file(&dst_path);


Reusing deterministic names in the global temp directory risks collisions between concurrent test runs (dst_path could be removed or overwritten by another run). Use a per-test TempDir (tempfile::TempDir) and derive src/dst paths from it to ensure isolation: let temp = tempfile::TempDir::new().unwrap(); let src_path = temp.path().join("src"); let dst_path = temp.path().join("dst");

Copilot · 2025-09-20T23:33:53Z

crates/vfox/src/lua_mod/http.rs

+        let temp_dir = std::env::temp_dir();
+        let path = temp_dir.join("vfox_test_download_file.txt");
+        let path_str = path.to_string_lossy().to_string();
+        let url = server.url("/index.json");


Static filename in a shared temp directory can lead to interference if tests run in parallel (file removed or contents overwritten). Use a unique path via tempfile::NamedTempFile (and pass its path to Lua) or tempfile::Builder::new().prefix("vfox_download_").tempfile() to avoid collisions.

Copilot · 2025-09-20T23:33:53Z

crates/vfox/src/lua_mod/archiver.rs

+        let temp_dir = std::env::temp_dir();
+        let dst_path = temp_dir.join("test_zip_dst");
+        let dst_path_str = dst_path.to_string_lossy().to_string();
+        let _ = std::fs::remove_dir_all(&dst_path);


Using a fixed directory name under the shared temp directory may cause flaky tests when run concurrently (one test cleaning up while another is using it). Switch to a unique TempDir (let temp = tempfile::TempDir::new().unwrap(); let dst_path = temp.path().join("unzip");) to ensure isolation and automatic cleanup.

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Replace httpmock dependency with wiremock to resolve the async-std discontinuation advisory (RUSTSEC-2025-0052). The httpmock crate has transitive dependencies on async-std which is no longer maintained and has known security vulnerabilities. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-20T23:42:40Z

crates/vfox/src/lua_mod/cmd.rs

-            -- Test with working directory
-            local result = cmd.exec("pwd", {cwd = "/tmp"})
-            assert(result:find("/tmp") ~= nil)
+            // Test with working directory


This should be a Lua comment using '--' instead of '//' which is a Rust comment syntax.

Suggested change

// Test with working directory

-- Test with working directory

crates/vfox/src/lua_mod/cmd.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-20T23:44:42Z

crates/vfox/src/lua_mod/http.rs

        let lua = Lua::new();
        mod_http(&lua).unwrap();
+
+        let url = server.uri() + "/get";


String concatenation using + creates temporary String allocations. Consider using format! macro for better performance: format!(\"{}/get\", server.uri())

Suggested change

let url = server.uri() + "/get";

let url = format!("{}/get", server.uri());

Copilot · 2025-09-20T23:44:42Z

crates/vfox/src/lua_mod/http.rs

        let lua = Lua::new();
        mod_http(&lua).unwrap();
+
+        let url = server.uri() + "/get";


String concatenation using + creates temporary String allocations. Consider using format! macro for better performance: format!(\"{}/get\", server.uri())

Suggested change

let url = server.uri() + "/get";

let url = format!("{}/get", server.uri());

Copilot · 2025-09-20T23:44:42Z

crates/vfox/src/lua_mod/http.rs

+        let temp_dir = tempfile::TempDir::new().unwrap();
+        let path = temp_dir.path().join("download_file.txt");
+        let path_str = path.to_string_lossy().to_string();
+        let url = server.uri() + "/index.json";


String concatenation using + creates temporary String allocations. Consider using format! macro for better performance: format!(\"{}/index.json\", server.uri())

Suggested change

let url = server.uri() + "/index.json";

let url = format!("{}/index.json", server.uri());

github-actions · 2025-09-20T23:58:01Z

Hyperfine Performance

`mise x -- echo`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.9.14 x -- echo`	20.8 ± 0.3	20.0	21.9	1.00
`mise x -- echo`	20.9 ± 0.9	19.9	38.2	1.00 ± 0.05

`mise env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.9.14 env`	20.0 ± 0.6	19.2	26.0	1.00
`mise env`	20.3 ± 0.8	19.4	31.6	1.01 ± 0.05

`mise hook-env`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.9.14 hook-env`	19.8 ± 0.4	18.8	20.8	1.00
`mise hook-env`	20.0 ± 0.5	19.0	23.3	1.01 ± 0.03

`mise ls`

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`mise-2025.9.14 ls`	17.4 ± 0.3	16.5	19.0	1.00
`mise ls`	17.5 ± 0.4	16.7	20.7	1.01 ± 0.03

`xtasks/test/perf`

Command	mise-2025.9.14	mise	Variance
install (cached)	174ms	✅ 105ms	+65%
ls (cached)	65ms	64ms	+1%
bin-paths (cached)	71ms	70ms	+1%
task-ls (cached)	499ms	484ms	+3%

✅ Performance improvement: install cached is 65%

## Summary Fixes CI test failures in the vfox crate by properly configuring TLS support for reqwest. ## Problem The vfox tests were failing in CI because reqwest was configured without TLS support, causing HTTPS requests to nodejs.org to fail with: ``` ConnectError("invalid URL, scheme is not http") ``` ## Solution Added `native-tls` to vfox's default features, matching mise's default TLS configuration approach. This ensures: - vfox tests work out of the box with TLS support - Consistency with mise's TLS strategy - mise continues to use `default-features = false` and explicitly controls which TLS implementation to use ## Changes - Added `native-tls` to vfox's default features - vfox now defaults to the same TLS implementation as mise ## Testing - All vfox tests pass locally - CI should pass with this change Follow-up to #6354 --------- Co-authored-by: Claude <noreply@anthropic.com>

@jayvdb

### 📦 Registry - add missing cargo backends by @jayvdb in [#6307](#6307) ### 🚀 Features - add env propagation by @Its-Just-Nans in [#6342](#6342) ### 🐛 Bug Fixes - **(aqua)** improve GitHub token handling for sigstore verification by @jdx in [#6351](#6351) - **(backend)** change dependency checks to warnings instead of errors by @jdx in [#6363](#6363) - **(npm)** improve error message when npm/bun is not installed by @jdx in [#6359](#6359) - **(vfox)** enable TLS support for reqwest to fix CI tests by @jdx in [#6356](#6356) ### 🚜 Refactor - **(registry)** convert to nested TOML sections format by @jdx in [#6361](#6361) ### 🧪 Testing - **(e2e)** resolve mise via PATH in backend missing deps test by @jdx in [#6362](#6362) - **(vfox)** replace flaky external HTTP tests with local mock server by @jdx in [#6354](#6354) ### 📦️ Dependency Updates - pin dependencies by @renovate[bot] in [#6243](#6243) ### Chore - **(install.sh)** add `MISE_INSTALL_MUSL` to force installing musl variants on Linux by @malept in [#6355](#6355) Co-authored-by: mise-en-dev <release@mise.jdx.dev>

@risu729

## [2025.9.16](https://github.com/jdx/mise/compare/v2025.9.15..v2025.9.16) - 2025-09-22 ### 📦 Registry - use npm backend for zbctl by @risu729 in [#6379](jdx/mise#6379) ### 🐛 Bug Fixes - **(aqua)** remove blake3 support from aqua checksum algorithms by @risu729 in [#6370](jdx/mise#6370) - **(aqua)** remove cosign and slsa-verifier dependencies by @risu729 in [#6371](jdx/mise#6371) - **(aqua)** remove cosign.experimental by @risu729 in [#6376](jdx/mise#6376) ### 📚 Documentation - minisign doesn't require cli by @risu729 in [#6369](jdx/mise#6369) ### Chore - ignore renovate new bot name by @risu729 in [#6364](jdx/mise#6364) ## [2025.9.15](https://github.com/jdx/mise/compare/v2025.9.14..v2025.9.15) - 2025-09-21 ### 📦 Registry - add missing cargo backends by @jayvdb in [#6307](jdx/mise#6307) ### 🚀 Features - add env propagation by @Its-Just-Nans in [#6342](jdx/mise#6342) ### 🐛 Bug Fixes - **(aqua)** improve GitHub token handling for sigstore verification by @jdx in [#6351](jdx/mise#6351) - **(backend)** change dependency checks to warnings instead of errors by @jdx in [#6363](jdx/mise#6363) - **(npm)** improve error message when npm/bun is not installed by @jdx in [#6359](jdx/mise#6359) - **(vfox)** enable TLS support for reqwest to fix CI tests by @jdx in [#6356](jdx/mise#6356) ### 🚜 Refactor - **(registry)** convert to nested TOML sections format by @jdx in [#6361](jdx/mise#6361) ### 🧪 Testing - **(e2e)** resolve mise via PATH in backend missing deps test by @jdx in [#6362](jdx/mise#6362) - **(vfox)** replace flaky external HTTP tests with local mock server by @jdx in [#6354](jdx/mise#6354) ### 📦️ Dependency Updates - pin dependencies by @renovate[bot] in [#6243](jdx/mise#6243) ### Chore - **(install.sh)** add `MISE_INSTALL_MUSL` to force installing musl variants on Linux by @malept in [#6355](jdx/mise#6355) ## [2025.9.14](https://github.com/jdx/mise/compare/v2025.9.13..v2025.9.14) - 2025-09-20 ### 🐛 Bug Fixes - fix an issue where Swift could not be installed on arm64 Ubuntu by @lish82 in [#6348](jdx/mise#6348) ### Chore - use cross to build on linux by @jdx in [#6346](jdx/mise#6346) ### New Contributors - @lish82 made their first contribution in [#6348](jdx/mise#6348) ## [2025.9.13](https://github.com/jdx/mise/compare/v2025.9.12..v2025.9.13) - 2025-09-19 ### 📦 Registry - remove deprecated virtualos by @jdx in [166379f](jdx/mise@166379f) - add trufflehog ([aqua:trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog)) by @risu729 in [#6316](jdx/mise#6316) ### 🚀 Features - **(aqua)** integrate native sigstore-verification for security verification by @jdx in [#6332](jdx/mise#6332) - **(docs)** improve search result readability with lighter teal background by @jdx in [#6328](jdx/mise#6328) - **(ui)** update logo as favicon and fix hover transitions by @jdx in [#6325](jdx/mise#6325) - **(vfox)** add file.read lua function by @malept in [#6333](jdx/mise#6333) - add documentation for "Environment in tasks" #5134 #5638 by @Its-Just-Nans in [#6329](jdx/mise#6329) ### 🐛 Bug Fixes - **(github)** correctly paginate releases/tags for private repos by @malept in [#6318](jdx/mise#6318) - **(hk)** exclude aqua-registry from prettier linting by @jdx in [#6327](jdx/mise#6327) - **(ui)** improve GitHub star badge layout and alignment by @jdx in [#6326](jdx/mise#6326) ### 📚 Documentation - change 'hello.py' to 'main.py' in python.md by @my1e5 in [#6319](jdx/mise#6319) - customize VitePress theme with unique branding by @jdx in [#6324](jdx/mise#6324) ### 📦️ Dependency Updates - update taiki-e/install-action digest to 0aa4f22 by @renovate[bot] in [#6334](jdx/mise#6334) - update rust crate comfy-table to v7.2.1 by @renovate[bot] in [#6335](jdx/mise#6335) - update rust crate console to v0.16.1 by @renovate[bot] in [#6336](jdx/mise#6336) - update rust crate indexmap to v2.11.4 by @renovate[bot] in [#6337](jdx/mise#6337) ### Chore - fixing typos by @Its-Just-Nans in [#6331](jdx/mise#6331) ### New Contributors - @Its-Just-Nans made their first contribution in [#6331](jdx/mise#6331) - @my1e5 made their first contribution in [#6319](jdx/mise#6319)

@risu729

## [2025.9.16](https://github.com/jdx/mise/compare/v2025.9.15..v2025.9.16) - 2025-09-22 ### 📦 Registry - use npm backend for zbctl by @risu729 in [#6379](jdx/mise#6379) ### 🐛 Bug Fixes - **(aqua)** remove blake3 support from aqua checksum algorithms by @risu729 in [#6370](jdx/mise#6370) - **(aqua)** remove cosign and slsa-verifier dependencies by @risu729 in [#6371](jdx/mise#6371) - **(aqua)** remove cosign.experimental by @risu729 in [#6376](jdx/mise#6376) ### 📚 Documentation - minisign doesn't require cli by @risu729 in [#6369](jdx/mise#6369) ### Chore - ignore renovate new bot name by @risu729 in [#6364](jdx/mise#6364) ## [2025.9.15](https://github.com/jdx/mise/compare/v2025.9.14..v2025.9.15) - 2025-09-21 ### 📦 Registry - add missing cargo backends by @jayvdb in [#6307](jdx/mise#6307) ### 🚀 Features - add env propagation by @Its-Just-Nans in [#6342](jdx/mise#6342) ### 🐛 Bug Fixes - **(aqua)** improve GitHub token handling for sigstore verification by @jdx in [#6351](jdx/mise#6351) - **(backend)** change dependency checks to warnings instead of errors by @jdx in [#6363](jdx/mise#6363) - **(npm)** improve error message when npm/bun is not installed by @jdx in [#6359](jdx/mise#6359) - **(vfox)** enable TLS support for reqwest to fix CI tests by @jdx in [#6356](jdx/mise#6356) ### 🚜 Refactor - **(registry)** convert to nested TOML sections format by @jdx in [#6361](jdx/mise#6361) ### 🧪 Testing - **(e2e)** resolve mise via PATH in backend missing deps test by @jdx in [#6362](jdx/mise#6362) - **(vfox)** replace flaky external HTTP tests with local mock server by @jdx in [#6354](jdx/mise#6354) ### 📦️ Dependency Updates - pin dependencies by @renovate[bot] in [#6243](jdx/mise#6243) ### Chore - **(install.sh)** add `MISE_INSTALL_MUSL` to force installing musl variants on Linux by @malept in [#6355](jdx/mise#6355) ## [2025.9.14](https://github.com/jdx/mise/compare/v2025.9.13..v2025.9.14) - 2025-09-20 ### 🐛 Bug Fixes - fix an issue where Swift could not be installed on arm64 Ubuntu by @lish82 in [#6348](jdx/mise#6348) ### Chore - use cross to build on linux by @jdx in [#6346](jdx/mise#6346) ### New Contributors - @lish82 made their first contribution in [#6348](jdx/mise#6348) ## [2025.9.13](https://github.com/jdx/mise/compare/v2025.9.12..v2025.9.13) - 2025-09-19 ### 📦 Registry - remove deprecated virtualos by @jdx in [166379f](jdx/mise@166379f) - add trufflehog ([aqua:trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog)) by @risu729 in [#6316](jdx/mise#6316) ### 🚀 Features - **(aqua)** integrate native sigstore-verification for security verification by @jdx in [#6332](jdx/mise#6332) - **(docs)** improve search result readability with lighter teal background by @jdx in [#6328](jdx/mise#6328) - **(ui)** update logo as favicon and fix hover transitions by @jdx in [#6325](jdx/mise#6325) - **(vfox)** add file.read lua function by @malept in [#6333](jdx/mise#6333) - add documentation for "Environment in tasks" #5134 #5638 by @Its-Just-Nans in [#6329](jdx/mise#6329) ### 🐛 Bug Fixes - **(github)** correctly paginate releases/tags for private repos by @malept in [#6318](jdx/mise#6318) - **(hk)** exclude aqua-registry from prettier linting by @jdx in [#6327](jdx/mise#6327) - **(ui)** improve GitHub star badge layout and alignment by @jdx in [#6326](jdx/mise#6326) ### 📚 Documentation - change 'hello.py' to 'main.py' in python.md by @my1e5 in [#6319](jdx/mise#6319) - customize VitePress theme with unique branding by @jdx in [#6324](jdx/mise#6324) ### 📦️ Dependency Updates - update taiki-e/install-action digest to 0aa4f22 by @renovate[bot] in [#6334](jdx/mise#6334) - update rust crate comfy-table to v7.2.1 by @renovate[bot] in [#6335](jdx/mise#6335) - update rust crate console to v0.16.1 by @renovate[bot] in [#6336](jdx/mise#6336) - update rust crate indexmap to v2.11.4 by @renovate[bot] in [#6337](jdx/mise#6337) ### Chore - fixing typos by @Its-Just-Nans in [#6331](jdx/mise#6331) ### New Contributors - @Its-Just-Nans made their first contribution in [#6331](jdx/mise#6331) - @my1e5 made their first contribution in [#6319](jdx/mise#6319)

test(vfox): replace flaky external HTTP tests with local mock server

7012e75

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings September 20, 2025 23:21

Copilot AI reviewed Sep 20, 2025

View reviewed changes

Merge branch 'main' into fix/harden-vfox-http-tests

3d91cc1

This comment was marked as outdated.

Sign in to view

test(vfox): use cross-platform temp directories in tests

f97d821

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

jdx requested a review from Copilot September 20, 2025 23:32

jdx enabled auto-merge (squash) September 20, 2025 23:32

Copilot AI reviewed Sep 20, 2025

View reviewed changes

jdx force-pushed the fix/harden-vfox-http-tests branch from 75a5704 to d1309ab Compare September 20, 2025 23:37

test(vfox): use isolated TempDir for concurrent test safety

4d65bf2

🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

jdx force-pushed the fix/harden-vfox-http-tests branch from d1309ab to 4d65bf2 Compare September 20, 2025 23:37

jdx requested a review from Copilot September 20, 2025 23:42

Copilot AI reviewed Sep 20, 2025

View reviewed changes

Update crates/vfox/src/lua_mod/cmd.rs

6de7ccc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

jdx requested a review from Copilot September 20, 2025 23:44

Copilot AI reviewed Sep 20, 2025

View reviewed changes

jdx merged commit b74b778 into main Sep 20, 2025
18 of 19 checks passed

jdx deleted the fix/harden-vfox-http-tests branch September 20, 2025 23:58

This was referenced Sep 21, 2025

chore: release 2025.9.15 #6352

Merged

fix(vfox): enable TLS support for reqwest to fix CI tests #6356

Merged

BrewTestBot mentioned this pull request Sep 22, 2025

mise 2025.9.15 Homebrew/homebrew-core#245213

Merged

	// Test with working directory
	-- Test with working directory

	let url = server.uri() + "/get";
	let url = format!("{}/get", server.uri());

	let url = server.uri() + "/index.json";
	let url = format!("{}/index.json", server.uri());

Uh oh!

Conversation

jdx commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

1. Replaced external HTTP tests with local mock server

2. Fixed cross-platform compatibility

3. Improved test isolation

4. Enhanced code readability

5. Resolved security advisory

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 20, 2025

Hyperfine Performance

mise x -- echo

mise env

mise hook-env

mise ls

xtasks/test/perf

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jdx commented Sep 20, 2025 •

edited

Loading

`mise x -- echo`

`mise env`

`mise hook-env`

`mise ls`

`xtasks/test/perf`