Skip to content

fix(hk): exclude aqua-registry from prettier linting#6327

Merged
jdx merged 2 commits intomainfrom
fix/hk-excludes
Sep 18, 2025
Merged

fix(hk): exclude aqua-registry from prettier linting#6327
jdx merged 2 commits intomainfrom
fix/hk-excludes

Conversation

@jdx
Copy link
Owner

@jdx jdx commented Sep 18, 2025

Summary

  • Bump hk version from 1.0.0 to 1.14.0 to get latest features including exclude support
  • Add exclude field to prettier config to skip crates/aqua-registry/aqua-registry directory
  • Fix prettier formatting issues in various documentation files
  • Exclude markdown files with special syntax from prettier formatting

Problems Fixed

1. Argument List Too Long

Running hk check --all was failing with "Argument list too long" error because prettier was trying to process too many files at once, particularly all the YAML files in the aqua-registry.

2. Broken Markdown Formatting

Prettier was incorrectly formatting markdown files that contain:

  • VitePress directives (::: blocks for warnings/danger/info)
  • Nested code blocks (converting ``` to ````)
  • Special indentation requirements

Solution

  1. Excluded the aqua-registry directory from prettier linting in hk.pkl
  2. Added problematic markdown files to .prettierignore to prevent prettier from breaking their formatting
  3. Files excluded: docs/plugin-usage.md, docs/plugin-publishing.md, CLAUDE.md

Test plan

  • Run hk check --all - now passes without errors
  • Run hk fix - works as expected
  • Verify prettier still checks other files properly
  • Verify markdown files maintain correct formatting

🤖 Generated with Claude Code

- Bump hk version from 1.0.0 to 1.14.0
- Add exclude field to prettier to skip crates/aqua-registry/aqua-registry
- Fix prettier formatting issues in various files
- Fixes 'Argument list too long' error when running hk check --all
Copilot AI review requested due to automatic review settings September 18, 2025 22:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the hk linting tool from version 1.0.0 to 1.14.0 and configures prettier to exclude the aqua-registry directory from linting to resolve "Argument list too long" errors when running hk check --all.

  • Updated hk package imports to use version 1.14.0
  • Added exclude configuration to prettier linter to skip crates/aqua-registry/aqua-registry directory
  • Fixed various prettier formatting issues across documentation and configuration files

Reviewed Changes

Copilot reviewed 20 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hk.pkl Updated hk version from 1.0.0 to 1.14.0 and added prettier exclude configuration
test/fixtures/mise-test-tool/README.md Applied prettier formatting fixes for markdown lists and escaping
docs/plugin-publishing.md Fixed markdown code block delimiters from triple to quadruple backticks
docs/.vitepress/theme/custom.css Condensed multi-line CSS gradients to single lines
CLAUDE.md Applied prettier formatting for markdown lists throughout document
.github/workflows/*.yml Converted single quotes to double quotes in YAML configurations
.claude/agents/*.md Applied prettier formatting for markdown lists in agent documentation
.agent-os/standards/*.md Applied prettier formatting for markdown lists in technical standards
.agent-os/product/*.md Applied prettier formatting for markdown lists in product documentation
.agent-os/instructions/*.md Applied prettier formatting for markdown lists in instruction guides

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- Add docs/plugin-usage.md, docs/plugin-publishing.md, and CLAUDE.md to .prettierignore
- These files contain VitePress directives (:::) and nested code blocks that prettier incorrectly formats
- Prevents prettier from breaking markdown formatting in these files
@jdx jdx enabled auto-merge (squash) September 18, 2025 22:30
@jdx jdx merged commit 4342ee6 into main Sep 18, 2025
20 checks passed
@jdx jdx deleted the fix/hk-excludes branch September 18, 2025 22:40
@github-actions
Copy link

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.9.12 x -- echo 19.9 ± 0.5 19.3 25.1 1.00
mise x -- echo 19.9 ± 0.2 19.3 20.7 1.00 ± 0.03

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.9.12 env 19.1 ± 0.3 18.6 22.0 1.00
mise env 19.3 ± 0.4 18.8 24.7 1.01 ± 0.02

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.9.12 hook-env 18.8 ± 0.2 18.4 19.4 1.00
mise hook-env 18.9 ± 0.2 18.3 20.5 1.01 ± 0.02

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.9.12 ls 16.5 ± 0.2 16.0 17.1 1.00
mise ls 16.8 ± 0.2 16.2 17.7 1.01 ± 0.02

xtasks/test/perf

Command mise-2025.9.12 mise Variance
install (cached) 167ms ✅ 103ms +62%
ls (cached) 63ms 63ms +0%
bin-paths (cached) 70ms 70ms +0%
task-ls (cached) 470ms 473ms +0%

✅ Performance improvement: install cached is 62%

@jdx jdx mentioned this pull request Sep 18, 2025
jdx added a commit that referenced this pull request Sep 19, 2025
### 📦 Registry

- remove deprecated virtualos by @jdx in
[166379f](166379f)
- add trufflehog
([aqua:trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog))
by @risu729 in [#6316](#6316)

### 🚀 Features

- **(aqua)** integrate native sigstore-verification for security
verification by @jdx in [#6332](#6332)
- **(docs)** improve search result readability with lighter teal
background by @jdx in [#6328](#6328)
- **(ui)** update logo as favicon and fix hover transitions by @jdx in
[#6325](#6325)
- **(vfox)** add file.read lua function by @malept in
[#6333](#6333)
- add documentation for "Environment in tasks" #5134 #5638 by
@Its-Just-Nans in [#6329](#6329)

### 🐛 Bug Fixes

- **(github)** correctly paginate releases/tags for private repos by
@malept in [#6318](#6318)
- **(hk)** exclude aqua-registry from prettier linting by @jdx in
[#6327](#6327)
- **(ui)** improve GitHub star badge layout and alignment by @jdx in
[#6326](#6326)

### 📚 Documentation

- change 'hello.py' to 'main.py' in python.md by @my1e5 in
[#6319](#6319)
- customize VitePress theme with unique branding by @jdx in
[#6324](#6324)

### 📦️ Dependency Updates

- update taiki-e/install-action digest to 0aa4f22 by @renovate[bot] in
[#6334](#6334)
- update rust crate comfy-table to v7.2.1 by @renovate[bot] in
[#6335](#6335)
- update rust crate console to v0.16.1 by @renovate[bot] in
[#6336](#6336)
- update rust crate indexmap to v2.11.4 by @renovate[bot] in
[#6337](#6337)

### Chore

- fixing typos by @Its-Just-Nans in
[#6331](#6331)

### New Contributors

- @Its-Just-Nans made their first contribution in
[#6331](#6331)
- @my1e5 made their first contribution in
[#6319](#6319)

---------

Co-authored-by: mise-en-dev <release@mise.jdx.dev>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 24, 2025
## [2025.9.16](https://github.com/jdx/mise/compare/v2025.9.15..v2025.9.16) - 2025-09-22

### 📦 Registry

- use npm backend for zbctl by @risu729 in [#6379](jdx/mise#6379)

### 🐛 Bug Fixes

- **(aqua)** remove blake3 support from aqua checksum algorithms by @risu729 in [#6370](jdx/mise#6370)
- **(aqua)** remove cosign and slsa-verifier dependencies by @risu729 in [#6371](jdx/mise#6371)
- **(aqua)** remove cosign.experimental by @risu729 in [#6376](jdx/mise#6376)

### 📚 Documentation

- minisign doesn't require cli by @risu729 in [#6369](jdx/mise#6369)

### Chore

- ignore renovate new bot name by @risu729 in [#6364](jdx/mise#6364)

## [2025.9.15](https://github.com/jdx/mise/compare/v2025.9.14..v2025.9.15) - 2025-09-21

### 📦 Registry

- add missing cargo backends by @jayvdb in [#6307](jdx/mise#6307)

### 🚀 Features

- add env propagation by @Its-Just-Nans in [#6342](jdx/mise#6342)

### 🐛 Bug Fixes

- **(aqua)** improve GitHub token handling for sigstore verification by @jdx in [#6351](jdx/mise#6351)
- **(backend)** change dependency checks to warnings instead of errors by @jdx in [#6363](jdx/mise#6363)
- **(npm)** improve error message when npm/bun is not installed by @jdx in [#6359](jdx/mise#6359)
- **(vfox)** enable TLS support for reqwest to fix CI tests by @jdx in [#6356](jdx/mise#6356)

### 🚜 Refactor

- **(registry)** convert to nested TOML sections format by @jdx in [#6361](jdx/mise#6361)

### 🧪 Testing

- **(e2e)** resolve mise via PATH in backend missing deps test by @jdx in [#6362](jdx/mise#6362)
- **(vfox)** replace flaky external HTTP tests with local mock server by @jdx in [#6354](jdx/mise#6354)

### 📦️ Dependency Updates

- pin dependencies by @renovate[bot] in [#6243](jdx/mise#6243)

### Chore

- **(install.sh)** add `MISE_INSTALL_MUSL` to force installing musl variants on Linux by @malept in [#6355](jdx/mise#6355)

## [2025.9.14](https://github.com/jdx/mise/compare/v2025.9.13..v2025.9.14) - 2025-09-20

### 🐛 Bug Fixes

- fix an issue where Swift could not be installed on arm64 Ubuntu by @lish82 in [#6348](jdx/mise#6348)

### Chore

- use cross to build on linux by @jdx in [#6346](jdx/mise#6346)

### New Contributors

- @lish82 made their first contribution in [#6348](jdx/mise#6348)

## [2025.9.13](https://github.com/jdx/mise/compare/v2025.9.12..v2025.9.13) - 2025-09-19

### 📦 Registry

- remove deprecated virtualos by @jdx in [166379f](jdx/mise@166379f)
- add trufflehog ([aqua:trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog)) by @risu729 in [#6316](jdx/mise#6316)

### 🚀 Features

- **(aqua)** integrate native sigstore-verification for security verification by @jdx in [#6332](jdx/mise#6332)
- **(docs)** improve search result readability with lighter teal background by @jdx in [#6328](jdx/mise#6328)
- **(ui)** update logo as favicon and fix hover transitions by @jdx in [#6325](jdx/mise#6325)
- **(vfox)** add file.read lua function by @malept in [#6333](jdx/mise#6333)
- add documentation for "Environment in tasks" #5134 #5638 by @Its-Just-Nans in [#6329](jdx/mise#6329)

### 🐛 Bug Fixes

- **(github)** correctly paginate releases/tags for private repos by @malept in [#6318](jdx/mise#6318)
- **(hk)** exclude aqua-registry from prettier linting by @jdx in [#6327](jdx/mise#6327)
- **(ui)** improve GitHub star badge layout and alignment by @jdx in [#6326](jdx/mise#6326)

### 📚 Documentation

- change 'hello.py' to 'main.py' in python.md by @my1e5 in [#6319](jdx/mise#6319)
- customize VitePress theme with unique branding by @jdx in [#6324](jdx/mise#6324)

### 📦️ Dependency Updates

- update taiki-e/install-action digest to 0aa4f22 by @renovate[bot] in [#6334](jdx/mise#6334)
- update rust crate comfy-table to v7.2.1 by @renovate[bot] in [#6335](jdx/mise#6335)
- update rust crate console to v0.16.1 by @renovate[bot] in [#6336](jdx/mise#6336)
- update rust crate indexmap to v2.11.4 by @renovate[bot] in [#6337](jdx/mise#6337)

### Chore

- fixing typos by @Its-Just-Nans in [#6331](jdx/mise#6331)

### New Contributors

- @Its-Just-Nans made their first contribution in [#6331](jdx/mise#6331)
- @my1e5 made their first contribution in [#6319](jdx/mise#6319)
riastradh pushed a commit to riastradh/pkgsrc-test20250901 that referenced this pull request Feb 8, 2026
## [2025.9.16](https://github.com/jdx/mise/compare/v2025.9.15..v2025.9.16) - 2025-09-22

### 📦 Registry

- use npm backend for zbctl by @risu729 in [#6379](jdx/mise#6379)

### 🐛 Bug Fixes

- **(aqua)** remove blake3 support from aqua checksum algorithms by @risu729 in [#6370](jdx/mise#6370)
- **(aqua)** remove cosign and slsa-verifier dependencies by @risu729 in [#6371](jdx/mise#6371)
- **(aqua)** remove cosign.experimental by @risu729 in [#6376](jdx/mise#6376)

### 📚 Documentation

- minisign doesn't require cli by @risu729 in [#6369](jdx/mise#6369)

### Chore

- ignore renovate new bot name by @risu729 in [#6364](jdx/mise#6364)

## [2025.9.15](https://github.com/jdx/mise/compare/v2025.9.14..v2025.9.15) - 2025-09-21

### 📦 Registry

- add missing cargo backends by @jayvdb in [#6307](jdx/mise#6307)

### 🚀 Features

- add env propagation by @Its-Just-Nans in [#6342](jdx/mise#6342)

### 🐛 Bug Fixes

- **(aqua)** improve GitHub token handling for sigstore verification by @jdx in [#6351](jdx/mise#6351)
- **(backend)** change dependency checks to warnings instead of errors by @jdx in [#6363](jdx/mise#6363)
- **(npm)** improve error message when npm/bun is not installed by @jdx in [#6359](jdx/mise#6359)
- **(vfox)** enable TLS support for reqwest to fix CI tests by @jdx in [#6356](jdx/mise#6356)

### 🚜 Refactor

- **(registry)** convert to nested TOML sections format by @jdx in [#6361](jdx/mise#6361)

### 🧪 Testing

- **(e2e)** resolve mise via PATH in backend missing deps test by @jdx in [#6362](jdx/mise#6362)
- **(vfox)** replace flaky external HTTP tests with local mock server by @jdx in [#6354](jdx/mise#6354)

### 📦️ Dependency Updates

- pin dependencies by @renovate[bot] in [#6243](jdx/mise#6243)

### Chore

- **(install.sh)** add `MISE_INSTALL_MUSL` to force installing musl variants on Linux by @malept in [#6355](jdx/mise#6355)

## [2025.9.14](https://github.com/jdx/mise/compare/v2025.9.13..v2025.9.14) - 2025-09-20

### 🐛 Bug Fixes

- fix an issue where Swift could not be installed on arm64 Ubuntu by @lish82 in [#6348](jdx/mise#6348)

### Chore

- use cross to build on linux by @jdx in [#6346](jdx/mise#6346)

### New Contributors

- @lish82 made their first contribution in [#6348](jdx/mise#6348)

## [2025.9.13](https://github.com/jdx/mise/compare/v2025.9.12..v2025.9.13) - 2025-09-19

### 📦 Registry

- remove deprecated virtualos by @jdx in [166379f](jdx/mise@166379f)
- add trufflehog ([aqua:trufflesecurity/trufflehog](https://github.com/trufflesecurity/trufflehog)) by @risu729 in [#6316](jdx/mise#6316)

### 🚀 Features

- **(aqua)** integrate native sigstore-verification for security verification by @jdx in [#6332](jdx/mise#6332)
- **(docs)** improve search result readability with lighter teal background by @jdx in [#6328](jdx/mise#6328)
- **(ui)** update logo as favicon and fix hover transitions by @jdx in [#6325](jdx/mise#6325)
- **(vfox)** add file.read lua function by @malept in [#6333](jdx/mise#6333)
- add documentation for "Environment in tasks" #5134 #5638 by @Its-Just-Nans in [#6329](jdx/mise#6329)

### 🐛 Bug Fixes

- **(github)** correctly paginate releases/tags for private repos by @malept in [#6318](jdx/mise#6318)
- **(hk)** exclude aqua-registry from prettier linting by @jdx in [#6327](jdx/mise#6327)
- **(ui)** improve GitHub star badge layout and alignment by @jdx in [#6326](jdx/mise#6326)

### 📚 Documentation

- change 'hello.py' to 'main.py' in python.md by @my1e5 in [#6319](jdx/mise#6319)
- customize VitePress theme with unique branding by @jdx in [#6324](jdx/mise#6324)

### 📦️ Dependency Updates

- update taiki-e/install-action digest to 0aa4f22 by @renovate[bot] in [#6334](jdx/mise#6334)
- update rust crate comfy-table to v7.2.1 by @renovate[bot] in [#6335](jdx/mise#6335)
- update rust crate console to v0.16.1 by @renovate[bot] in [#6336](jdx/mise#6336)
- update rust crate indexmap to v2.11.4 by @renovate[bot] in [#6337](jdx/mise#6337)

### Chore

- fixing typos by @Its-Just-Nans in [#6331](jdx/mise#6331)

### New Contributors

- @Its-Just-Nans made their first contribution in [#6331](jdx/mise#6331)
- @my1e5 made their first contribution in [#6319](jdx/mise#6319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants