Skip to content

cursor rule conventional commits#5595

Closed
jdx wants to merge 10 commits into
mainfrom
cursor-rule-conventional-commits
Closed

cursor rule conventional commits#5595
jdx wants to merge 10 commits into
mainfrom
cursor-rule-conventional-commits

Merge remote-tracking branch 'origin/main' into vfox-backend

b560ed9
Select commit
Loading
Failed to load commit list.
Cursor / Cursor BugBot completed Jul 12, 2025 in 2m 21s

BugBot Review

BugBot completed review and found 2 potential issues

Request ID: serverGenReqId_a658942d-ab9c-4827-a8fd-3bd91e687cb9

Details

Bug: Markdown File Contains Duplicate Content

The conventional_commits.mdc file has its entire content duplicated from line 38 to 69. The duplicated section starts with malformed markdown on line 38, where the "Common Scopes" list is concatenated directly with "## Conventional Commits (REQUIRED)" due to a missing newline.

.cursor/rules/conventional_commits.mdc#L36-L69

https://github.com/jdx/mise/blob/b560ed99bebb149a01eb48e9bfe100577207226e/.cursor/rules/conventional_commits.mdc#L36-L69

Fix in Cursor • Fix in Web

Bug: Command Execution Incompatibility and Injection Vulnerability

The exec function in cmd.rs directly executes user-provided commands via sh -c. This design introduces two critical issues:

  1. Cross-platform incompatibility: It fails on Windows systems, which require cmd /c or powershell -c for command execution.
  2. Command injection vulnerability: Lack of input validation allows malicious plugin code to execute arbitrary system commands.

crates/vfox/src/lua_mod/cmd.rs#L12-L34

mise/crates/vfox/src/lua_mod/cmd.rs

Lines 12 to 34 in b560ed9

fn exec(_lua: &Lua, (command,): (String,)) -> LuaResult<String> {
use std::process::Command;
let output = Command::new("sh")
.arg("-c")
.arg(&command)
.output()
.map_err(|e| mlua::Error::RuntimeError(format!("Failed to execute command: {}", e)))?;
let stdout = String::from_utf8_lossy(&output.stdout);
let stderr = String::from_utf8_lossy(&output.stderr);
if output.status.success() {
Ok(stdout.to_string())
} else {
Err(mlua::Error::RuntimeError(format!(
"Command failed with status {}: {}",
output.status,
stderr
)))
}
}

Fix in Cursor • Fix in Web

BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

View more details on Cursor