fix(aqua): parse templates in version_filter#5341
Merged
Merged
Conversation
risu729
force-pushed
the
parse-version-filter-template
branch
from
fd50c1b to
c0931d2
Compare
Owner
|
nice that this actually makes it a lot simpler |
risu729
added a commit
to risu729/mise
that referenced
this pull request
Jun 13, 2025
This reverts commit 809cfd4.
jdx
pushed a commit
that referenced
this pull request
Jun 13, 2025
### 🚀 Features - support matching_regex from the ubi backend by [@yjoer](https://github.com/yjoer) in [#5320](#5320) ### 🐛 Bug Fixes - **(aqua)** parse templates in version_filter by [@risu729](https://github.com/risu729) in [#5341](#5341) - **(registry)** use extract_all for docker-slim by [@risu729](https://github.com/risu729) in [#5342](#5342) ### 🚜 Refactor - **(getting-started)** update powershell profile instructions by [@Armaldio](https://github.com/Armaldio) in [#5340](#5340) ### 📦️ Dependency Updates - update docker/build-push-action digest to 2634353 by [@renovate[bot]](https://github.com/renovate[bot]) in [#5338](#5338) - update jdx/mise-action digest to 13abe50 by [@renovate[bot]](https://github.com/renovate[bot]) in [#5339](#5339) ### New Contributors - @yjoer made their first contribution in [#5320](#5320)
jdx
pushed a commit
that referenced
this pull request
Jun 13, 2025
Reverts #5341 My apologies, I didn't check well and misunderstood that it fixed the issue. However, the warnings were just suppressed because there was a versions cache.
Contributor
Author
|
This was caused by the wrong operator precedence between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aqua:docker/clican be installed, but it caused warnings.#4832
This is because the registry uses
Versionin itsversion_filter.https://github.com/aquaproj/aqua-registry/blob/8f3a2ae02b5b56a9583ddb1c9ee9739ceff19f9e/pkgs/docker/cli/rootless/registry.yaml
This PR resolves the issue by parsing aqua templates in
version_filter.