Skip to content

feat(registry): add docker cli#4832

Closed
acesyde wants to merge 5 commits into
jdx:mainfrom
acesyde:feature/docker
Closed

feat(registry): add docker cli#4832
acesyde wants to merge 5 commits into
jdx:mainfrom
acesyde:feature/docker

Conversation

@acesyde

@acesyde acesyde commented Apr 12, 2025

Copy link
Copy Markdown
Contributor
  • feat: add docker cli in the registry

cargo run --bin mise -- tool docker-cli

Backend:            aqua:docker/cli
Description:        Docker CE CLI  
Installed Versions: 28.0.4         
Tool Options:       [none] 

@acesyde acesyde changed the title feat: add docker cli feat(registry): add docker cli Apr 12, 2025
@risu729

risu729 commented Apr 12, 2025

Copy link
Copy Markdown
Contributor

JFYI, I got these warnings when I tried to install aqua:docker/cli.

$ mise use aqua:docker/cli
mise WARN  [aqua:docker/cli] aqua version filter error: Invalid operands for operator contains
...
mise WARN  [aqua:docker/cli] aqua version filter error: Invalid operands for operator contains
mise ~/.config/mise/config.toml tools: aqua:docker/cli@28.0.4

I guess contains in not (Version contains "beta" or Version contains "rc") is not supported.
https://github.com/aquaproj/aqua-registry/blob/8f3a2ae02b5b56a9583ddb1c9ee9739ceff19f9e/pkgs/docker/cli/rootless/registry.yaml

@acesyde

acesyde commented Apr 13, 2025

Copy link
Copy Markdown
Contributor Author

@risu729 you're right for the warning, i use this package with mise use aqua:docker/cli at my work in a devcontainer and it works like a charm

@jdx

jdx commented Apr 19, 2025

Copy link
Copy Markdown
Owner

We should avoid using aqua packages with version filters. I don't think it's possible for mise to use those tools effectively.

@acesyde

acesyde commented Apr 19, 2025

Copy link
Copy Markdown
Contributor Author

@jdx you're right, but i'm not the author of the aqua package 😅

@jdx jdx closed this Apr 19, 2025
@acesyde acesyde deleted the feature/docker branch April 20, 2025 05:52
@eread

eread commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

@risu729 you're right for the warning, i use this package with mise use aqua:docker/cli at my work in a devcontainer and it works like a charm

@risu729 do you know what would be required in the Aqua project to fix the warnings?

@risu729

risu729 commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

@eread This warning is an issue of mise, not aqua-registry. So, to answer your question, nothing needs to be changed in aqua.
Please read: #3896

@eread

eread commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

@eread This warning is an issue of mise, not aqua-registry. So, to answer your question, nothing needs to be changed in aqua. Please read: #3896

Thanks @risu729. I wondered about not having to use version filters, per: #4832 (comment).

@risu729

risu729 commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

@eread I'm not sure of the exact reason, but I guess it's because it'll be complicated to support it.
Also, version_filter seems to be deprecated in favour of version_prefix, so not many packages use them. ref: aquaproj/aqua#1545
https://aquaproj.github.io/docs/reference/registry-config/version-filter/

jdx pushed a commit that referenced this pull request Jun 13, 2025
`aqua:docker/cli` can be installed, but it caused warnings. 
#4832

```
mise WARN  [aqua:docker/cli] aqua version filter error: Invalid operands for operator contains
```

This is because the registry uses `Version` in its `version_filter`.

https://github.com/aquaproj/aqua-registry/blob/8f3a2ae02b5b56a9583ddb1c9ee9739ceff19f9e/pkgs/docker/cli/rootless/registry.yaml

This PR resolves the issue by parsing aqua templates in
`version_filter`.
@risu729

risu729 commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

@acesyde Could you reopen this PR?

I fixed the warnings in #5341.

jdx pushed a commit that referenced this pull request Jun 23, 2025
- feat: add docker cli in the registry

`cargo run --bin mise -- tool docker-cli`

```shell
Backend:            aqua:docker/cli
Description:        Docker CE CLI  
Installed Versions: 28.2.2        
Tool Options:       [none] 
```

#4832
andreabedini pushed a commit to andreabedini/mise that referenced this pull request Jul 1, 2025
- feat: add docker cli in the registry

`cargo run --bin mise -- tool docker-cli`

```shell
Backend:            aqua:docker/cli
Description:        Docker CE CLI  
Installed Versions: 28.2.2        
Tool Options:       [none] 
```

jdx#4832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants