[JamBalaya56562]

A request whose response body dropped partway through failed on the first try, even with http_retries set. mise already counts a broken body read as transient, and #14049 extended that to an HTTP/2 stream reset during the read. But the retry loop ended once the response headers arrived, and callers read the body afterwards, outside it:

let resp = self.get_async(url).await?; // retried
let json = resp.json().await?;         // not retried

So a version list or release page cut off mid-transfer failed with error decoding response body, with no retry.

The retry loop now takes a reader and runs it inside each attempt. These callers read the whole body inside the retry:

• json / json_headers / json_headers_with_headers
• get_text and everything built on its request, including the cached variants
• get_bytes
• a version list read with version_regex. It used to fetch the response and read it outside the loop, so it bypassed get_text's HTML check. It now goes through get_text with a new allow_html(), which keeps the HTML pages that regex parsing expects.

Callers that need the response itself, such as HEAD, streamed downloads and error-body inspection, pass the response through unchanged, so their behavior is the same. get_html is unchanged too: it checks Content-Type before reading, and reading inside the retry would download bodies it currently discards.

This takes over #12974 by @Binlogo, which pr-closer closed after 7 days of failing checks. The HTTP client has since moved to crates/mise-util/src/http.rs, so this ports the change and does not replay it. They are credited as co-author. The original description gives background: a 27 MB GitHub releases page in mise-versions that drops mid-stream. As it says, retrying alone will not always rescue a response that large.

Review threads on #12974:

• Greptile: the version_regex path was still unretried. Fixed, as described above.
• CodeRabbit: json_headers resolves auth headers before checking offline mode. Not changed here. That order predates this PR: get_async resolved the headers before get_async_with_headers checked offline mode. It is a separate fix.

Validation

• New unit tests in crates/mise-util/src/http/tests/retry.rs:
  • get_text, json and get_bytes each get a response cut off before its Content-Length on the first attempt and a full one on the second. Each returns the second body after two connections.
  • allow_html() returns an HTML page, which is still rejected without it.
• cargo test -p mise-util --lib -- http::tests::retry passes all 33 tests with this change, the four new ones among them.
• The three retry tests, run against main's code, fail with error decoding response body, the symptom this fixes.

AI-assisted — Tool: Claude Code; model: anthropic/claude-opus-5-5; version: unavailable.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Text, JSON, and byte requests now retry transient errors encountered while reading response bodies, not just errors encountered when sending requests.
  • Updated authentication settings are retained across retry attempts.
• New Features
  • Text requests can accept HTML responses when enabled.
  • Version lists using a custom pattern can now be fetched from HTML pages.

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 928cfa17-2aea-44cd-8c2d-e0e14a24ecaa

---

📥 Commits

Reviewing files that changed from the base of the PR and between 6805afe and c13e392.

---

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: f0b00f8c-1fdb-4649-b345-bc951f38fbe8

---

📥 Commits

Reviewing files that changed from the base of the PR and between 5c6e084 and 6805afe.

---

📒 Files selected for processing (1)

• crates/mise-util/src/http.rs

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

---

---

📝 Walkthrough

Walkthrough

HTTP request paths now retry errors that occur while reading response bodies. Text requests gain an allow_html() option. The regex-configured version-fetch path uses this option.

Changes

HTTP response handling

Layer / File(s)	Summary
Shared retry execution crates/mise-util/src/http.rs	A shared retry operation invokes a response reader during each request attempt. The HTTPS-fallback request wrapper uses the shared retry state and attempt options.
Byte and JSON body retries crates/mise-util/src/http.rs, crates/mise-util/src/http/tests/retry.rs	Byte and JSON request paths read response bodies inside the retry operation. Tests cover retries after truncated bodies.
Text retries and HTML acceptance crates/mise-util/src/http.rs, crates/mise-util/src/http/tests/retry.rs, src/backend/version_list.rs	Text requests read response bodies inside retries and add allow_html(). The regex-configured version-fetch path enables HTML acceptance. Tests cover text body retries and HTML acceptance or rejection.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant TextRequest
  participant send_with_retries
  participant HTTPClient
  TextRequest->>send_with_retries: send request with response reader
  send_with_retries->>HTTPClient: send request
  HTTPClient-->>send_with_retries: response
  send_with_retries->>send_with_retries: read response body
  send_with_retries->>HTTPClient: retry after body-read error

Loading

Suggested reviewers: jdx

---

Merge Risk: ⚪ Minimal · up to 6805a

Response-body failures can now be retried, while the inspected JSON and version-list paths retain their existing behavior. No material issue remains before merge.

Pre-merge checks | 4 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: retrying HTTP requests when response-body reads fail mid-stream.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}