Repository navigation
fix(bootstrap): don't create history state or fail on its lock unless writing files #14029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b5a3a9c
fix(bootstrap): don't fail when another history operation holds the lock
jdx f21c10b
docs(history): describe how history activates and the kill switch
jdx d4b6e09
docs(history): clarify what history.enabled=false stops and when boot…
jdx d033e50
fix(bootstrap): open the history journal at the first write
jdx 12a30c9
fix(bootstrap): don't hold the operation state lock while opening the…
0ba7ca9
fix(bootstrap): close a lazily opened journal whose scope already ended
jdx 65bc399
fix(bootstrap): only continue unjournaled on a first-write lock miss
jdx b919f07
fix(bootstrap): tie a lazy journal to the scope that started it
jdx 6a16523
fix(bootstrap): keep hook children attached to a lazy bootstrap
jdx 7bf8c5e
fix(bootstrap): warn when a run that gained tracking already gave up …
jdx 06e7c45
fix(bootstrap): check whether a run records history off the async worker
jdx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.