Repository navigation
fix(backend): preserve Windows ZIP preference - #12200
Conversation
jdx#12156 scored TarZst at 15, tying Windows ZIP, so zip only won through the shortest-name tiebreak. Rank tar.zst > tar.xz > other tarballs below ZIP. Co-authored-by: Taku Kodama <risu729@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe archive matcher now ranks Windows ZIP files above tar.zst and tar.xz files. Tests verify the score ordering and selection behavior when all three formats are available. ChangesArchive scoring
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change preserves Windows ZIP preference and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR restores a strict Windows ZIP preference while retaining the intended ordering among tar archive formats.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The revised scores preserve existing archive-format ordering outside Windows, make the Windows ZIP preference strict rather than dependent on a tiebreaker, and add coverage for both scoring and final selection. Important Files Changed
Reviews (1): Last reviewed commit: "fix(backend): keep windows zip strictly ..." | Re-trigger Greptile |
Summary
tar.zst>tar.xz> other tarball ordering below ZIPWhat was wrong in #12156
#12156 raised
TarZstto score 15, equal to the existing Windows ZIP score. ZIP then won only incidentally through the shortest-name tiebreak, so the change did not actually retain the documented Windows ZIP preference.This restores a strict ordering: Windows ZIP at 15, then
tar.zst/tar.xz/ other tarballs at 12 / 11 / 10. The regression test checks the scores directly and verifies ZIP is selected over bothtar.zstandtar.xz.The companion draft #12199 handles the residual bzip shorthand and checksum-stem gaps in #12156 and adds the missing Elide-style preferred-name integration coverage.
Tests
cargo test --bin mise backend::asset_matchercargo clippy --bin mise --all-features --tests -- -D warningsAI-assisted — Tool: Codex; model: OpenAI/GPT-5; version: unavailable.