Skip to content

chore(nix): remove unused inputs - #11104

Merged
jdx merged 2 commits into
jdx:mainfrom
risu729:agent/remove-stale-nix-just
Jul 20, 2026
Merged

jdx merged 2 commits into
jdx:mainfrom
risu729:agent/remove-stale-nix-just

Conversation

@risu729

@risu729 risu729 commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • remove just from the Nix development shell
  • remove the unused fetchFromGitHub argument from default.nix
  • keep the remaining Nix build and development inputs unchanged

Why

The repository migrated its Justfile tasks to mise in 2024 and deleted the Justfile, so the development shell no longer uses just. The package source is taken directly from the repository with lib.cleanSource, leaving fetchFromGitHub unused in the default.nix function interface.

Impact

The Nix development shell installs one fewer unused tool, and default.nix no longer requests an unused callPackage input. Build and runtime behavior are unchanged.

Validation

  • mise run lint-fix
  • git diff --check

Nix is not installed in the local validation environment, so flake evaluation was not run.

Summary by CodeRabbit

  • Chores
    • Updated the default development environment toolset by removing the Just command runner.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The Nix configuration removes just from the development shell inputs and removes fetchFromGitHub from the top-level package function parameters.

Changes

Nix configuration updates

Layer / File(s) Summary
Configuration input cleanup
flake.nix, default.nix
Removes just from the default development shell inputs and fetchFromGitHub from the package function arguments.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: mise-en-dev

Poem

A bunny trims the Nix delight,
just hops out of shell tonight.
One unused name is tucked away,
The tooling list grows neat today.
Hop, hop—clean config bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change by removing unused Nix inputs from the configuration.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes two unused Nix inputs: fetchFromGitHub from default.nix's function parameters (the package source is provided via lib.cleanSource ./., so it was never needed) and just from the dev shell in flake.nix (the Justfile was deleted when tasks migrated to mise in 2024).

  • default.nix: Drops fetchFromGitHub from the callPackage interface; lib.cleanSource ./. is already used as the source, confirming the parameter was dead.
  • flake.nix: Removes just from nativeBuildInputs; no Justfile exists in the repository, so the tool was being installed superfluously.

Confidence Score: 5/5

Safe to merge — removes two provably unused inputs with no effect on build or runtime behavior.

Both removals are verified: fetchFromGitHub does not appear anywhere in default.nix body (source is lib.cleanSource ./.), and no Justfile exists in the repository, confirming just was an unused dev-shell dependency. No functional code paths are affected.

No files require special attention.

Important Files Changed

Filename Overview
default.nix Removes fetchFromGitHub from the function parameter list; confirmed unused since the package uses lib.cleanSource ./. for its source.
flake.nix Removes just from dev shell nativeBuildInputs; confirmed no Justfile exists in the repo, making this a correct cleanup.

Reviews (2): Last reviewed commit: "chore(nix): remove unused fetchFromGitHu..." | Re-trigger Greptile

@risu729 risu729 changed the title chore(nix): remove unused just dependency chore(nix): remove unused inputs Jul 17, 2026
@risu729
risu729 marked this pull request as ready for review July 17, 2026 19:13
@jdx
jdx merged commit bf3c0de into jdx:main Jul 20, 2026
33 checks passed
@risu729
risu729 deleted the agent/remove-stale-nix-just branch July 20, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants