Skip to content

chore: remove stale cargo-deny advisory ignores#10372

Merged
jdx merged 1 commit into
mainfrom
chore/remove-stale-deny-ignores
Jun 13, 2026
Merged

chore: remove stale cargo-deny advisory ignores#10372
jdx merged 1 commit into
mainfrom
chore/remove-stale-deny-ignores

Conversation

@jdx

@jdx jdx commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove cargo-deny advisory ignores that no longer match dependency advisories
  • remove the obsolete rustls-webpki explanatory block tied to those ignores

Test

  • cargo deny check

This PR was generated by an AI coding assistant.


Note

Low Risk
Config-only cleanup with no runtime code changes; risk is limited to cargo deny check failing if any removed advisory still matches the lockfile.

Overview
Trims deny.toml so cargo deny check advisories only lists ignores that still apply to the current dependency graph.

Removes RUSTSEC-2024-0370 (proc-macro-error via sigstore) and four rustls-webpki 0.102 entries (RUSTSEC-2026-0049, 0098, 0099, 0104) plus the long comment about sigstore-tsa / rustls-webpki = "0.102". Unchanged ignores: RUSTSEC-2026-0173, RUSTSEC-2023-0071, RUSTSEC-2025-0119.

Reviewed by Cursor Bugbot for commit 3d125c1. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated security advisory configuration management.

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the deny.toml configuration file to modify the cargo deny advisory ignore list. The [advisories].ignore array is consolidated to contain only three specific RustSec advisory IDs (RUSTSEC-2026-0173, RUSTSEC-2023-0071, RUSTSEC-2025-0119) with their associated reason annotations, removing nine lines of previously ignored advisory entries.

Changes

Dependency Advisory Configuration

Layer / File(s) Summary
Advisory ignore list update
deny.toml
The [advisories].ignore configuration is reduced to three specified RustSec advisory IDs with their reason annotations, removing previously ignored entries and maintaining only the active advisory ignores.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • jdx/mise#10269: Both PRs modify deny.toml's [advisories].ignore list to manage RustSec advisory ignores, specifically involving RUSTSEC-2026-0173 in advisory ignore configuration.

Poem

🐰 Nine lines of worry hop away,
Three advisories stay to play,
The deny list is sleek and bright,
Dependencies sleep tight tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: remove stale cargo-deny advisory ignores' directly and clearly describes the main change in the changeset: removing outdated advisory ignore entries from deny.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jdx jdx enabled auto-merge (squash) June 13, 2026 01:32
@greptile-apps

greptile-apps Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Cleans up deny.toml by removing five advisory ignore entries that no longer match active dependencies, along with the explanatory comment block for the rustls-webpki 0.102 advisories.

  • Removes RUSTSEC-2024-0370 (proc-macro-error from sigstore) and four RUSTSEC-2026-xxxx rustls-webpki 0.102 entries, indicating those dependencies have been upgraded or dropped since the ignores were added.
  • Leaves the three still-needed ignores (RUSTSEC-2026-0173, RUSTSEC-2023-0071, RUSTSEC-2025-0119) untouched.

Confidence Score: 5/5

Safe to merge — removes stale advisory suppression entries with no impact on runtime behavior.

The change only removes advisory ignores that no longer correspond to active dependencies; cargo deny check validates correctness. Nothing is introduced or modified, only cleaned up.

No files require special attention.

Important Files Changed

Filename Overview
deny.toml Removes 5 stale RUSTSEC advisory ignores (RUSTSEC-2024-0370 and the 4 rustls-webpki 0.102 entries) along with their associated explanatory comment block; remaining 3 ignores are untouched.

Reviews (1): Last reviewed commit: "chore: remove stale cargo-deny advisory ..." | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.5 x -- echo 17.8 ± 0.8 16.3 21.5 1.00
mise x -- echo 18.5 ± 1.1 16.8 35.5 1.04 ± 0.08

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.5 env 17.8 ± 0.8 16.2 21.1 1.00
mise env 18.1 ± 0.7 16.6 20.6 1.02 ± 0.06

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.5 hook-env 18.2 ± 0.7 16.8 22.2 1.00
mise hook-env 18.8 ± 0.8 17.0 23.5 1.03 ± 0.06

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.5 ls 14.8 ± 0.7 13.4 18.5 1.00
mise ls 15.4 ± 0.7 13.9 18.3 1.04 ± 0.07

xtasks/test/perf

Command mise-2026.6.5 mise Variance
install (cached) 130ms 131ms +0%
ls (cached) 57ms 59ms -3%
bin-paths (cached) 61ms 64ms -4%
task-ls (cached) 123ms 126ms -2%

@jdx jdx merged commit 5393223 into main Jun 13, 2026
34 checks passed
@jdx jdx deleted the chore/remove-stale-deny-ignores branch June 13, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant