Enable more parallel tests in data/transactions/logic/evalAppTxn_test.go#5
Closed
michaeldiamant wants to merge 1 commit intojdtzmn:paralleltest-logic-packagefrom
Closed
Conversation
Author
|
Closing in favor of algorand#4937. |
jasonpaulos
pushed a commit
that referenced
this pull request
Jan 19, 2023
go-algorand v3.11.3-stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends algorand#4931 to remove
nolint:paralleltestin several cases where I think it's safe.During my inspection, I didn't see the mentioned shared usage. As a sanity check, I ran each changed test numerous times to check for non-determinism (e.g.
go test ./data/transactions/logic -run "TestInnerTxIDCaching" -count=1000).