Tests: Enable more parallel tests in data/transactions/logic/evalAppTxn_test.go

[michaeldiamant]

Extends #4931 to remove nolint:paralleltest in several cases where I think it's safe.

During my inspection, I didn't see the mentioned shared usage. As a sanity check, I ran each changed test numerous times to check for non-determinism (e.g. go test ./data/transactions/logic -run "TestInnerTxIDCaching" -count=1000).

[codecov]

Codecov Report

Merging #4937 (026f0aa) into master (026f0aa) will not change coverage.
The diff coverage is n/a.

❗ Current head 026f0aa differs from pull request most recent head 360640c. Consider uploading reports for the commit 360640c to get more accurate results

@@           Coverage Diff           @@
##           master    #4937   +/-   ##
=======================================
  Coverage   53.50%   53.50%           
=======================================
  Files         432      432           
  Lines       53624    53624           
=======================================
  Hits        28691    28691           
  Misses      22702    22702           
  Partials     2231     2231           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jasonpaulos]

Thanks for this improvement. Adding unified := unified solves the shared loop variable dependency