Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix privatescope method resolution bug #916

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Fix privatescope method resolution bug #916

merged 1 commit into from
Jun 29, 2023

Commits on Jun 29, 2023

  1. Fix privatescope method resolution bug 

    When resolving a `GenericInstanceMethod` for a `privatescope` method that has the same signature as other methods, `MetadataResolver.GetMethod` would incorrectly return the first method with the same name.

The fix for this seems to be an optimization opportunity as well.  Although I have to admit it feels a little to easy.  Please make sure I'm not overlooking some reason why this fix is not safe.

A added 2 variations of tests.

`PrivateScope` - These tests were fine and passed as is.  This is because the instruction operands are MethodDefinitions and therefore didn't need to be resolved by `MetadataResolver`

`PrivateScopeGeneric` - This test triggered the bug.
    @mrvoorhe
    mrvoorhe committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    024b9c5 View commit details
    Browse the repository at this point in the history