Fix privatescope method resolution bug #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resolving a `GenericInstanceMethod` for a `privatescope` method that has the same signature as other methods, `MetadataResolver.GetMethod` would incorrectly return the first method with the same name. The fix for this seems to be an optimization opportunity as well. Although I have to admit it feels a little to easy. Please make sure I'm not overlooking some reason why this fix is not safe. A added 2 variations of tests. `PrivateScope` - These tests were fine and passed as is. This is because the instruction operands are MethodDefinitions and therefore didn't need to be resolved by `MetadataResolver` `PrivateScopeGeneric` - This test triggered the bug.
mrvoorhe
commented
Jun 29, 2023
|
|
||
| // The equality failure isn't going to be very helpful since both methods will have the same ToString value, | ||
| // so before we assert equality, we'll assert that the method is compiler controlled because that is the key difference | ||
| Assert.IsTrue(second_call_resolved.IsCompilerControlled, "Expected the method reference to resolve to a compiler controlled method"); |
There was a problem hiding this comment.
This is the first assertion that would fail. It would fail because second_call_resolved incorrectly resolved to first_call_resolved
jbevain
approved these changes
Jun 29, 2023
|
We keep learning interesting things. Thank you for the PR! |
mrvoorhe
added a commit
to Unity-Technologies/cecil
that referenced
this pull request
Oct 11, 2023
When resolving a `GenericInstanceMethod` for a `privatescope` method that has the same signature as other methods, `MetadataResolver.GetMethod` would incorrectly return the first method with the same name. The fix for this seems to be an optimization opportunity as well. Although I have to admit it feels a little to easy. Please make sure I'm not overlooking some reason why this fix is not safe. A added 2 variations of tests. `PrivateScope` - These tests were fine and passed as is. This is because the instruction operands are MethodDefinitions and therefore didn't need to be resolved by `MetadataResolver` `PrivateScopeGeneric` - This test triggered the bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving a
GenericInstanceMethodfor aprivatescopemethod that has the same signature as other methods,MetadataResolver.GetMethodwould incorrectly return the first method with the same name.The fix for this seems to be an optimization opportunity as well. Although I have to admit it feels a little too easy. Please make sure I'm not overlooking some reason why this fix is not safe.
I added 2 variations of tests.
PrivateScope- These tests were fine and passed as is. This is because the instruction operands are MethodDefinitions and therefore didn't need to be resolved byMetadataResolverPrivateScopeGeneric- This test triggered the bug.