Version bump to 3.0.0 #800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 9 9
Lines 723 723
Branches 141 141
=======================================
Hits 672 672
Misses 34 34
Partials 17 17
Continue to review full report at Codecov.
|
gasman
added a commit
to gasman/wagtail
that referenced
this pull request
Apr 28, 2022
The next release of django-taggit [will change slugs to allow_unicode=True](jazzband/django-taggit#797), which breaks our check for missing migrations. This change is not released yet, but the fix is needed now so that we can run against django-taggit git master for our tests against Django main. It's also dependent on the version bump happening at the django-taggit end: jazzband/django-taggit#800
|
Yep, I was thinking of setting up a new release. The unicode slugification change in particular is a big breaking change. I am going to figure out how to get get us to a release here... |
|
@gasman I've gone and made a full release here. Closing this PR as I believe it is no longer needed |
gasman
added a commit
to wagtail/wagtail
that referenced
this pull request
May 2, 2022
* Fix test migrations for django-taggit 3.0.0 (forthcoming) The next release of django-taggit [will change slugs to allow_unicode=True](jazzband/django-taggit#797), which breaks our check for missing migrations. This change is not released yet, but the fix is needed now so that we can run against django-taggit git master for our tests against Django main. It's also dependent on the version bump happening at the django-taggit end: jazzband/django-taggit#800 * Allow django-taggit 3.x as a dependency and drop special case when testing against Django main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully not controversial (#797 is an upcoming breaking change, and django-taggit has followed semver in previous cases like this) but if you're curious why I'm proposing this right now: we're testing Wagtail against Django git main, which necessitates also installing django-taggit git master for the 4.1 fixes (#791, #792). Our test suite includes a check for missing migrations, and currently that's being triggered by the
allow_unicodechange in #797. Bumping the version now will allow us to hack a version check into our migrations and keep them working against both the current release version and git master.