Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump to 3.0.0 #800

Closed
wants to merge 1 commit into from

Conversation

gasman
Copy link
Contributor

@gasman gasman commented Apr 28, 2022

Hopefully not controversial (#797 is an upcoming breaking change, and django-taggit has followed semver in previous cases like this) but if you're curious why I'm proposing this right now: we're testing Wagtail against Django git main, which necessitates also installing django-taggit git master for the 4.1 fixes (#791, #792). Our test suite includes a check for missing migrations, and currently that's being triggered by the allow_unicode change in #797. Bumping the version now will allow us to hack a version check into our migrations and keep them working against both the current release version and git master.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #800 (961d715) into master (191d727) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #800   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files           9        9           
  Lines         723      723           
  Branches      141      141           
=======================================
  Hits          672      672           
  Misses         34       34           
  Partials       17       17           
Impacted Files Coverage Δ
taggit/__init__.py 50.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191d727...961d715. Read the comment docs.

gasman added a commit to gasman/wagtail that referenced this pull request Apr 28, 2022
The next release of django-taggit [will change slugs to allow_unicode=True](jazzband/django-taggit#797), which breaks our check for missing migrations.

This change is not released yet, but the fix is needed now so that we can run against django-taggit git master for our tests against Django main. It's also dependent on the version bump happening at the django-taggit end: jazzband/django-taggit#800
@rtpg
Copy link
Contributor

rtpg commented May 2, 2022

Yep, I was thinking of setting up a new release. The unicode slugification change in particular is a big breaking change.

I am going to figure out how to get get us to a release here...

@rtpg
Copy link
Contributor

rtpg commented May 2, 2022

@gasman I've gone and made a full release here. Closing this PR as I believe it is no longer needed

@rtpg rtpg closed this May 2, 2022
gasman added a commit to wagtail/wagtail that referenced this pull request May 2, 2022
* Fix test migrations for django-taggit 3.0.0 (forthcoming)

The next release of django-taggit [will change slugs to allow_unicode=True](jazzband/django-taggit#797), which breaks our check for missing migrations.

This change is not released yet, but the fix is needed now so that we can run against django-taggit git master for our tests against Django main. It's also dependent on the version bump happening at the django-taggit end: jazzband/django-taggit#800

* Allow django-taggit 3.x as a dependency and drop special case when testing against Django main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants