Handle path_infos / reverse_path_infos cached properties (Dj4.1 compatibility) #792
Conversation
The old behaviour of assertQuerysetEqual automatically calling repr is deprecated in Django 3.2 https://docs.djangoproject.com/en/4.0/releases/3.2/#id3 and dropped in Django 4.1.
As of django/django@a697424 there are two new cached properties path_infos and reverse_path_infos which Django will use in preference to the get_path_info() and get_reverse_path_info() methods when not passing a filtered_relation argument. TaggableManager is patching these methods, and therefore it now needs to provide these cached properties to match Django's expectations.
These are introduced in django/django@a697424 to be used in preference to get_path_info / reverse_path_info when not passing filtered_relation.
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
==========================================
+ Coverage 92.74% 92.91% +0.17%
==========================================
Files 9 9
Lines 703 720 +17
Branches 136 140 +4
==========================================
+ Hits 652 669 +17
Misses 34 34
Partials 17 17
Continue to review full report at Codecov.
|
|
alright, looks good! Seems like the next steps here would be to actually prep a release with this 4.1 support |
|
@rtpg Thanks! I don't think there's any particular hurry to get a release out with this fix - at least until Django 4.1 is in release candidate stage, which is still a couple of months away (final release is scheduled for August). My motivation for fixing this now is to keep Wagtail's test suite passing against Django main so that we get early warning of any upcoming breaking changes - and for that purpose it's no problem for us to test against django-taggit master. |
In django/django@a697424 / django/django#14750, Django has introduced two new cached properties
path_infosandreverse_path_infosto be used in preference to theget_path_info()andget_reverse_path_info()methods when not passing afiltered_relationargument.TaggableManager is patching these methods, so to avoid Django bypassing them (specifically in
django.db.query.Query.names_to_path) it needs to provide these cached properties too.For additional bonus points, we also update TaggableManager's
_get_mm_case_path_infoand_get_gfk_case_path_infomethods to make use of the new cached properties where available.This (along with #791, incorporated here) gets the test suite passing again on the current Django main branch.