Skip to content

docs: merge upstream on-demand skill layout and doc rewrites into house - #67

Merged
jazz127 merged 4 commits into
housefrom
fm/firstmate-upstream-5872-merge-r1
Sep 27, 2026
Merged

jazz127 merged 4 commits into
housefrom
fm/firstmate-upstream-5872-merge-r1

Conversation

@jazz127

@jazz127 jazz127 commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Intent

Bring the latest upstream firstmate main into the fork's house line, and carry each of our own house features' instruction text into upstream's new layout through that feature's own housefeature/ branch.

Upstream has three new commits since house last merged it: kunchenguid/firstmate PR 5872 moves situational sections of the always-loaded AGENTS.md into on-demand agent-only skills (operational-home-layout, session-start-recovery, validation-supervision, ship-landing, scout-completion, away-quiet-supervision, a trigger index, plus fmx-respond additions), and two readability rewrites of docs/turnend-guard.md and docs/calm.md. A trial merge conflicts only in AGENTS.md, in two places where upstream replaced a whole section with a skill pointer while house had added lines inside it: the home-layout listing (house added the optional seat in config/crew-dispatch.json, the project value of config/herdr-presentation-spaces, config/ready-session-timeout, and the <id>.ready-timeout state record) and the PR ready/landing section (house added the PR reporting-boundary evidence read-back, evidence-validation=failed, stale-attestation diagnostic, PR-body preflight, and contradictory scenario-claim lines). Every other house addition merges cleanly.

Changes to our own features' text must go through each owning feature's durable housefeature/<name> branch, not be edited directly on the upstream-merge branch, so each feature stays self-contained and extractable.

What Changed

This merge brings upstream main at 49a218bb into house as a merge commit. It takes upstream's on-demand skill pointers for the two conflicting AGENTS.md sections and includes the upstream rewrites of docs/turnend-guard.md and docs/calm.md. All other house additions remain.

The following nine house instruction lines are deliberately absent until their owning feature branches update the new skills:

  1. config/crew-dispatch.json: optional seat - housefeature/dock-seat-credentials.
  2. config/herdr-presentation-spaces: project mode - housefeature/herdr-project-spaces.
  3. config/ready-session-timeout: opt-in ready worker stop - housefeature/ready-session-timeout.
  4. <id>.ready-timeout: stopped-worker state record - housefeature/ready-session-timeout.
  5. Published PR body read-back at the reporting boundary - housefeature/evidence-boundary-coverage.
  6. The evidence-validation=failed reporting marker - housefeature/evidence-boundary-coverage.
  7. The stale-attestation diagnostic - housefeature/attestation-head-boundary.
  8. PR-body preflight before publication - housefeature/pr-evidence-preflight.
  9. Contradictory driven-scenario claim refusal - housefeature/evidence-contradiction.

These are four follow-up areas delivered through seven owning housefeature/* branches: dispatch seat, Herdr project spaces, ready-session timeout, and PR evidence validation. Each branch first receives its own update PR. Merge this upstream PR into house first, then merge the seven housefeature/* integration PRs into house immediately afterward. Do not merge house into those feature branches.

Risk Assessment

A documentation and instruction merge. The nine omitted house lines are assigned above to follow-up feature branches; those branches must land immediately after this merge.

Testing

evidence-artifact: /tmp/fm-firstmate-upstream-5872-merge-r1/doc-checks.txt
evidence-command: bash /tmp/fm-firstmate-upstream-5872-merge-r1/capture-evidence.sh > /tmp/fm-firstmate-upstream-5872-merge-r1/doc-checks.txt 2>&1
evidence-captured: 2026-09-27T08:29:22Z

The merge touches instruction prose and a docs manifest. The captured local checks are synthetic/offline built-CLI validation: the documentation checker, its focused test, a whitespace check, and the merge-parent read. No runtime scenario was driven against a real account. The nine omitted lines are assigned above to their feature branches.

  • Live validation: ⚠️ no-surface - 0 of 3 scenarios driven live against the product
Scenario Result Live Evidence
Agents that load the merged docs get upstream's new on-demand skills and the rewritten turnend-guard/calm docs ⏸️ untested no No live-validatable surface: these are agent-instruction and prose files with no runtime behavior. The repo's doc checker passed.
House AGENTS.md additions outside the two conflicted sections survive the merge ⏸️ untested no No live-validatable surface: this is instruction prose. The dropped lines in the conflicted sections are handed to the housefeature branches under the recorded round-1 decision.
The merged documentation-audiences.json inventory and local links stay consistent ⏸️ untested no No live-validatable surface: this is a docs manifest checked by its validator, not a user-facing product path. The real consumer passed.
  • Outcome: ⚠️ 1 warning across 1 run (21.6s)

Pipeline

Updates from git push no-mistakes

✅ **intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

✅ **Review** - passed

✅ No issues found.

⚠️ **Test** - 1 warning
  • ⚠️ this change has no live-validatable surface; proceed without live validation? (0 of 3 scenarios were driven live against the product); Agents that load the merged docs get upstream's new on-demand skills and the rewritten turnend-guard/calm docs: No live-validatable surface: these are agent-instruction and prose files with no runtime behavior. The repo's doc checker passed.; House AGENTS.md additions outside the two conflicted sections survive the merge: No live-validatable surface: this is instruction prose. The dropped lines in the conflicted sections are handed to the housefeature branches under the recorded round-1 decision.; The merged documentation-audiences.json inventory and local links stay consistent: No live-validatable surface: this is a docs manifest checked by its validator, not a user-facing product path. The real consumer passed.
  • Live validation: ⚠️ no-surface - 0 of 3 scenarios driven live against the product
Scenario Result Live Evidence
Agents that load the merged docs get upstream's new on-demand skills and the rewritten turnend-guard/calm docs ⏸️ untested no No live-validatable surface: these are agent-instruction and prose files with no runtime behavior. The repo's doc checker passed.
House AGENTS.md additions outside the two conflicted sections survive the merge ⏸️ untested no No live-validatable surface: this is instruction prose. The dropped lines in the conflicted sections are handed to the housefeature branches under the recorded round-1 decision.
The merged documentation-audiences.json inventory and local links stay consistent ⏸️ untested no No live-validatable surface: this is a docs manifest checked by its validator, not a user-facing product path. The real consumer passed.
  • git diff --stat c62f9818 46264a23 (all 16 changed files are AGENTS.md, .agents/skills/, or docs/)
  • bin/fm-doc-audience-check.sh (the manifest's real consumer: ok, surfaces=118, local_links=709)
  • git grep for leftover merge-conflict markers in AGENTS.md, .agents, and docs (none found)
  • git log -1 --format=%P HEAD (merge parents are house c62f9818 and upstream 49a218bb)
✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.

tmchow and others added 4 commits September 26, 2026 22:13
* docs: make calm easier to read

Restructure the Calm mode prose into sections, lists, and tables without changing documented behavior. Every original heading, anchor, fenced code block, inline-code span, link target, number, and quoted string is preserved.

* docs: restore reload case in calm override lead-in

The Built-in tool override collisions lead-in covers a session that reloads with Calm already on, as the original text did.
* docs: make turnend-guard easier to read

Restructure the turn-end guard doc's prose into shorter sections, lists, and tables without changing documented behavior. Every original heading, anchor, inline identifier, link target, and number is kept.

* no-mistakes(review): Restore legacy-only scope on TERM retirement sentence

* no-mistakes(review): Name Cursor park behavior in live e2e test line
…henguid#5872)

* docs: move situational AGENTS.md sections into on-demand skills

Backpass memory optimization: shrink the always-loaded AGENTS.md by moving
situational contracts (home layout, session-start recovery, validation and
landing supervision, scout completion, away/quiet supervision, Relay
ownership) into agent-only skills loaded at their triggers, with a trigger
index skill.

* docs: classify the new on-demand skills' documentation audience

Register the seven new agent-only skills as agent-runtime docs and fix a
link in validation-supervision that kept its AGENTS.md-relative path.

* docs: close load-timing gaps found by the live regression check

- load validation-supervision whenever an ask-user finding is decided or
  answered, so forbid --yes and process-every-return reach the worker
- keep the mid-task captain-ask rule, the unconfirmed network-checks rule,
  and the worker account pin rule inline in AGENTS.md
- fix cross-references that still pointed at moved AGENTS.md sections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

house-only Part of our own line by design - not intended for upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants