Allow changing nseg after initialization #436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #418 and #426. It allows to set
nseg
after initialization of the module. This is achieved with a newset_ncomp
method. This PR is the final requirement for a new release with these features.API
Works for branches:
...for branches within a cell:
...and for branches read from SWC files, in which case it reuses the xyzr to compute optional radiuses:
Assumption and
Raises
The
set_ncomp
function will raise an error if:In addition, unlike the data was read from an SWC file,
.set_ncomp()
raises an error if:Finally, we currently raise
NotImplementedError
if theModule
is aNetwork
, e.g. forThis is because I do not want to deal with synapse indexing for now.
We also raise a
NotImplementedError
if theModule
is an entireCell
, e.g. for