Allow custom jaxley solvers to have different nseg per branch
#426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldeistler
changed the title
jaxley solvers to have different nseg per branch
michaeldeistler
force-pushed
the
different-nseg-for-custom2
branch
9 times, most recently
from
c668807
to
9e782e3
Compare
michaeldeistler
force-pushed
the
different-nseg-for-custom2
branch
from
d16c894
to
54b45a5
Compare
This was referenced Sep 21, 2024
Closed
michaeldeistler
force-pushed
the
different-nseg-for-custom2
branch
6 times, most recently
from
c501d08
to
ff736a3
Compare
jnsbck
approved these changes
Sep 23, 2024
michaeldeistler
force-pushed
the
different-nseg-for-custom2
branch
2 times, most recently
from
8d449de
to
dfdc887
Compare
michaeldeistler
force-pushed
the
different-nseg-for-custom2
branch
from
dfdc887
to
62f8561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #418, this will also allow different nseg per branch for the jaxley.thomas solver. This works by masking the tridiagonal system in every branch.
In addition, it also uses more invasively
.comp_edgesto build the conductances of the custom solver more easily. Before this PR,.comp_edgeshad only been used for thejax.sparsesolver.Replaces #425 which was closed due to difficult merge conflicts.
In addition, this contains a bugfix and closes #429.