Refactor URLClassLoaderTest.testGetPackage to testGetDefinedPackage

[gayanW]

ClassLoader.getPackage(String) is deprecated. This refactors URLClassLoaderTest to use ClassLoader.getDefinedPackage(String) instead.

gov.nasa.jpf.test.java.net.URLClassLoaderTest.TestClassLoader is only used within gov.nasa.jpf.test.java.net.URLClassLoaderTest.
gov.nasa.jpf.test.java.net.URLClassLoaderTest.TestClassLoader#getPackage
is being removed as it is no longer being used once the test being refactored.

Fixes: #71

[cyrille-artho]

Thanks. The new test fails; can you please try to see why?

[junit] Running gov.nasa.jpf.test.java.net.URLClassLoaderTest [junit] Tests run: 20, Failures: 20, Errors: 0, Skipped: 0, Time elapsed: 0.729 sec

It would be good if at least this test succeeded; this would allow us to figure out how to load the base classes.

[gayanW]

It fails due to #53. It did fail before. However I tried remote debugging the method, executing the assertions independently, and they do pass.

I'll keep #53 and the class loading issue for later, as I think it will be good do some research prior to fixing those.

[cyrille-artho]

Yes, it failed earlier. However, it would be nice if we could see exactly why it failed, as the test is very small. It is strange that the assertions seem to pass in the debugger. I expected the first one to be the one that fails (as the base classes can maybe not be loaded in the same way in Java 9+). Perhaps the class loading mechanism in the debugger is slightly different, in which case some tracing/logging statements ("debug by println") are needed to find the root cause. Gayan Weerakutti wrote:

…

It fails due to #53 <#53>. It did fail before. However I tried remote debugging the method, executing the assertions independently, and they do pass. I'll keep #53 <#53> and the class loading issue for later, as I think it will be good do some research prior to fixing those. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#80 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG9eR-dU4dOpWWoMA2HsZEDGV0z5r3yvks5t6iJDgaJpZM4Ueo_L>.

-- Regards, Cyrille Artho - http://artho.com/ Never offend people with style when you can offend them with substance. -- Sam Brown, "The Washington Post", January 26, 1977

[gayanW]

The stacktrace when test fails is as in issue #53. If #53 is being fixed then it will throw the classloading exception.

[cyrille-artho]

I see; #53 may not be so easy to fix. I'll merge this one, and we can work on #53 later.