warning: [deprecation] getPackage(String) in ClassLoader has been deprecated

[gayanW]

Deprecation warning 'getPackage(String) in ClassLoader has been deprecated' when build with JDK 9 and later:

[javac] /home/travis/build/javapathfinder/jpf-core/src/tests/gov/nasa/jpf/test/java/net/URLClassLoaderTest.java:68: warning: [deprecation] getPackage(String) in ClassLoader has been deprecated
[javac] 	protected Package getPackage(String name) {
[javac] 	                  ^
[javac] /home/travis/build/javapathfinder/jpf-core/src/tests/gov/nasa/jpf/test/java/net/URLClassLoaderTest.java:69: warning: [deprecation] getPackage(String) in ClassLoader has been deprecated
[javac]       return super.getPackage(name);
[javac]                   ^

jpf-core/src/tests/gov/nasa/jpf/test/java/net/URLClassLoaderTest.java

Lines 67 to 70 in 18a0c42

	@Override
	protected Package getPackage(String name) {
	return super.getPackage(name);
	}

Travis log:
https://travis-ci.org/javapathfinder/jpf-core/builds/385707808#L2456-L2461

References:
cr.openjdk.java.net/~iris/se/10/latestSpec/api/java/lang/ClassLoader.html#getPackage(java.lang.String)

[gayanW]

Simplest solution would be just to annotate the override method with @SuppressWarnings("deprecation")

The overridden method is being called in here:

jpf-core/src/tests/gov/nasa/jpf/test/java/net/URLClassLoaderTest.java

Lines 482 to 497 in 18a0c42

	@Test
	public void testGetPackage() throws ClassNotFoundException, MalformedURLException {
	movePkgOut();
	if(verifyNoPropertyViolation()) {
	URL[] urls = { new URL(dirUrl) };
	TestClassLoader cl = new TestClassLoader(urls);
	assertNotNull(cl.getPackage("java.lang"));
	assertNull(cl.getPackage("non_existing_package"));
	assertNull(cl.getPackage("classloader_specific_tests"));
	String cname = pkg + ".Class1";
	cl.loadClass(cname);
	assertNotNull(cl.getPackage("classloader_specific_tests"));
	}
	movePkgBack();
	}

Another possible solution would be to refactor cl.getPackage to use the method ClassLoader#getDefinedPackage instead. But as the name suggests the test is written specially for getPackage.

[cyrille-artho]

Perhaps the test still passes when using getDefinedPackage. In that case, changing the method is the best way (note that getDefinedPackage was introduced in Java 9).

[gayanW]

Thanks for the info. Is it okay that we keep the test name as testGetPackage as we no longer be calling getPackage but getDefinedPackage.

[cyrille-artho]

Gayan Weerakutti wrote:

Thanks for the info. Is it okay that we keep the test name as |testGetPackage| as we no longer be calling |getPackage| but |getDefinedPackage|. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#71 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG9eRwg68wd9TKkAmE4F1Tfir6noIRBuks5t5o-ogaJpZM4UU1pO>.

I see; please change the test name to testGetDefinedPackage for consistency. -- Regards, Cyrille Artho - http://artho.com/ No problem is so formidable that you can't just walk away from it. -- C. Schulz