Fixup for the PR: #58 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace attempts to instantiate a new Long, Integer, Short or Byte object from a primitive long, integer, short or byte argument, with more efficient static method valueOf() (introduced in Java 5), which will cache objects for values between -128 and 127 inclusive. We can't use assertEquals(42, obj.i); in gov.nasa.jpf.test.vm.reflection.ConstructorTest#testConstructorCallInteger as both assertEquals (Object, Object) and assertEquals (int, int) in TestJPF match (Ambiguous method call) Issue: javapathfinder#47
This is a fixup for the commit ddd3c52 Issue: javapathfinder#47
gayanW
added a commit
to gayanW/jpf-core
that referenced
this pull request
May 31, 2018
Double (double) is deprecated. It is suggested that we use the static factory #valueOf(double), as it is likely to yield significantly better space and time performance. This is a fixup for issue: javapathfinder#47 This is a follow-up to the PR: javapathfinder#59
gayanW
added a commit
to gayanW/jpf-core
that referenced
this pull request
May 31, 2018
Double (double) is deprecated. It is suggested that we use the static factory #valueOf(double), as it is likely to yield significantly better space and time performance. This is a fixup for issue: javapathfinder#47 This is a follow-up to the PR: javapathfinder#59
gayanW
added a commit
to gayanW/jpf-core
that referenced
this pull request
May 31, 2018
Double (double) is deprecated. It is suggested that we use the static factory #valueOf(double), as it is likely to yield significantly better space and time performance. This is a fixup for issue: javapathfinder#47 This is a follow-up to the PR: javapathfinder#59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the PR: #58
Fixes: #47