Deprecated constructor calls with primitive argument - Xlint warnings

[gayanW]

Several deprecation warnings are showing up on the build logs when compiled with JDK 9 and later.

[javac] /home/travis/build/javapathfinder/jpf-core/src/main/gov/nasa/jpf/vm/StackFrame.java:247: warning: [deprecation] Byte(byte) in Byte has been deprecated
[javac]           return new Byte((byte) v);
[javac]                  ^
[javac] /home/travis/build/javapathfinder/jpf-core/src/main/gov/nasa/jpf/vm/StackFrame.java:249: warning: [deprecation] Character(char) in Character has been deprecated
[javac]           return new Character((char) v);
[javac]                  ^
[javac] /home/travis/build/javapathfinder/jpf-core/src/main/gov/nasa/jpf/vm/StackFrame.java:251: warning: [deprecation] Short(short) in Short has been deprecated
[javac]           return new Short((short) v);
[javac]                  ^
[javac] /home/travis/build/javapathfinder/jpf-core/src/main/gov/nasa/jpf/vm/StackFrame.java:253: warning: [deprecation] Integer(int) in Integer has been deprecated
[javac]           return new Integer(v);
[javac]                  ^

https://travis-ci.org/javapathfinder/jpf-core/builds/379204138#L2431

[gayanW]

These deprecation warnings are mainly due to the use of the Number constructor on the primitive types. We could change those to use the static method valueOf instead. However there seems to have cases where the Number constructor is used intendedly.

So for instance in the BoxObjectCacheTest:
https://github.com/javapathfinder/jpf-core/blob/master/src/tests/gov/nasa/jpf/test/java/lang/BoxObjectCacheTest.java#L137

Just want to make sure that there will be no other side effects once we made the changes.

The other workaround is to simply disable Xlint:deprecation. But in that case we won't gain the performance benefits claimed by valueOf.

@cyrille-artho @Octarine-J

[cyrille-artho]

Hi Gayan, This is indeed a special case. I think it's safe to convert all the normal cases and use @SuppressWarnings("deprecation") for the rare cases where bypassing the Integer cache is intentional. With the annotation, we don't have to turn off the warning globally and still get to see and fix the other instances of deprecated methods. Gayan Weerakutti wrote:

…

These deprecation warnings are mainly due to the use of the Number constructor on the primitive types. We could change those to use the static method valueOf instead. However there seems to have cases where the Number constructor is used intendedly. So for instance in the BoxObjectCacheTest: https://github.com/javapathfinder/jpf-core/blob/master/src/tests/gov/nasa/jpf/test/java/lang/BoxObjectCacheTest.java#L137 Just want to make sure that there will be no other side effects once we made the changes. The other workaround is to simply disable |Xlint:deprecation|. But in that case we won't gain the performance benefits claimed by |valueOf|. @cyrille-artho <https://github.com/cyrille-artho> @Octarine-J <https://github.com/Octarine-J> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#47 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG9eR-553nrxOL3LD8F1n_7MIKtAOseXks5tz_eLgaJpZM4UFqKh>.

-- Regards, Cyrille Artho - http://artho.com/ Always think of something new; this helps you forget your last rotten idea. -- Seth Frankel

[cyrille-artho]

Good work. There are still a few open cases in "tests", so I've reopened this issue.

[cyrille-artho]

This type of warning has now been eliminated for entire jpf-core.
Other warnings remain (to be resolved in other issues).