-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to node-sass 2.0.1 #100
Conversation
@nicolo-ribaudo Do you have time to help me test this update? |
Yes, is there any special case to test? |
General workflows. I'm seeing some issues with the grunt build currently. I'll let you know when I can post a zip. |
Can I just clone the jasonsanjose/v2 branch or the zip build may have some other issues? |
Try the zip to make sure that the node dependencies are getting included correctly. |
Conflicts: Compiler.js node/1.1.4-3/SASSDomain.js node/1.1.4-3/render.js
Ok, I installed the zip.
|
Thanks. I'll take a look. I haven't tested on windows yet. |
I'll try to fix the error thrown while using Ruby this weekend.
|
Seems fixed. |
Are you talking about your fix in this other PR #99? |
Conflicts: node/1.1.4-3/render.js
…different drive letters.
@nicolo-ribaudo I updated the build here https://github.com/jasonsanjose/brackets-sass/releases/tag/2.0.1-101. I just added basic compass support for compiling on save only, no live preview support yet. I think this is good enough to call experimental. I posted an example project here https://github.com/jasonsanjose/compass-example. I think I've finally ironed out all the windows path problems during live preview and on save for both ruby and libsass. Feel free to use the https://github.com/jasonsanjose/bourbon-example project to test compiling and live preview in both the main file and partial file. |
Upgrade to node-sass 2.0.1
Changes to .brackets.json settings