Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node-sass 2.0.1 #100

Merged
merged 11 commits into from
Mar 5, 2015
Merged

Upgrade to node-sass 2.0.1 #100

merged 11 commits into from
Mar 5, 2015

Conversation

jasonsanjose
Copy link
Owner

Changes to .brackets.json settings

{
    {
       "sass.compiler": "libsass|ruby", // default: "libsass"
       "sass.compass": false // default: false, experimental compile-only support (no live preview). requires config.rb at project root
    },
    "path": {
        "path/to/my.scss": {
            "sass.options": {
                "sourceMap": true | "relative/path/from/input.css.map" // default: true
            }
        }
    }
}

@jasonsanjose
Copy link
Owner Author

@nicolo-ribaudo Do you have time to help me test this update?

@nicolo-ribaudo
Copy link
Contributor

Yes, is there any special case to test?

@jasonsanjose
Copy link
Owner Author

General workflows. I'm seeing some issues with the grunt build currently. I'll let you know when I can post a zip.

@jasonsanjose
Copy link
Owner Author

@nicolo-ribaudo
Copy link
Contributor

Can I just clone the jasonsanjose/v2 branch or the zip build may have some other issues?

@jasonsanjose
Copy link
Owner Author

Try the zip to make sure that the node dependencies are getting included correctly.

@jasonsanjose jasonsanjose mentioned this pull request Feb 26, 2015
Conflicts:
	Compiler.js
	node/1.1.4-3/SASSDomain.js
	node/1.1.4-3/render.js
@nicolo-ribaudo
Copy link
Contributor

Ok, I installed the zip.


[node-error 10:03:41 PM] [Launcher] uncaught exception at top level, exiting. TypeError: Arguments to path.resolve must be strings
    at Object.exports.resolve (path.js:116:15)
    at C:\Users\Nicolo\AppData\Roaming\Brackets\extensions\user\jasonsanjose.brackets-sass\node\2.0.1\SASSDomain.js:341:39
    at Array.forEach (native)
    at C:\Users\Nicolo\AppData\Roaming\Brackets\extensions\user\jasonsanjose.brackets-sass\node\2.0.1\SASSDomain.js:335:29
    at renderMsg._callback (C:\Users\Nicolo\AppData\Roaming\Brackets\extensions\user\jasonsanjose.brackets-sass\node\2.0.1\SASSDomain.js:266:18)
    at ChildProcess._nextRender.messageListener (C:\Users\Nicolo\AppData\Roaming\Brackets\extensions\user\jasonsanjose.brackets-sass\node\2.0.1\SASSDomain.js:186:13)
    at ChildProcess.g (events.js:180:16)
    at ChildProcess.EventEmitter.emit (events.js:98:17)
    at handleMessage (child_process.js:318:10)
    at Pipe.channel.onread (child_process.js:345:11)

@jasonsanjose
Copy link
Owner Author

Thanks. I'll take a look. I haven't tested on windows yet.

@nicolo-ribaudo
Copy link
Contributor

nicolo-ribaudo commented Feb 26, 2015 via email

@nicolo-ribaudo
Copy link
Contributor

Seems fixed.
But css files aren't generated if the project isn't on c:/ and a partial is imported.

@jasonsanjose
Copy link
Owner Author

Seems fixed.
But css files aren't generated if the project isn't on c:/ and a partial is imported.

Are you talking about your fix in this other PR #99?

@jasonsanjose
Copy link
Owner Author

@nicolo-ribaudo I updated the build here https://github.com/jasonsanjose/brackets-sass/releases/tag/2.0.1-101.

I just added basic compass support for compiling on save only, no live preview support yet. I think this is good enough to call experimental. I posted an example project here https://github.com/jasonsanjose/compass-example.

I think I've finally ironed out all the windows path problems during live preview and on save for both ruby and libsass. Feel free to use the https://github.com/jasonsanjose/bourbon-example project to test compiling and live preview in both the main file and partial file.

@jasonsanjose
Copy link
Owner Author

Merging this now thanks to some testing from @tijtij and @onetrev. Need to clean up README and post release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants