Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path issue in Windows #89

Closed
tijtij opened this issue Feb 1, 2015 · 8 comments
Closed

Path issue in Windows #89

tijtij opened this issue Feb 1, 2015 · 8 comments
Assignees
Milestone

Comments

@tijtij
Copy link

tijtij commented Feb 1, 2015

Don't know if this is an issue with the Bourbon example, brackets-sass, or libsass but compiling is broken when the project files are located on my D drive.

This is what app.css.map looks like:

{
  "version": 3,
  "file": "app.css",
  "sources": [
    "C:/D:/bourbon-example-master/scss/app.scss",
    "C:/D:/bourbon-example-master/bower_components/bourbon/dist/_bourbon.scss",
    "C:/D:/bourbon-example-master/scss/partial.scss",
...

Previously reported in issue #21 (comment)

@ofhouse
Copy link

ofhouse commented Feb 22, 2015

Same here.
Found out that the issue was caused by this code.
Unfortunately I'm not really experienced with Node.js so I don't know how to debug Node.js code to fix that :
console.log() / Webkit Dev-Tools doesn't work here.

Edit: It's a bug related to path.resolve(), more details here.
Think it needs a workaround for this behavior.

@nicolo-ribaudo
Copy link
Contributor

Fixed: #99

@jasonsanjose
Copy link
Owner

FWIW the path that we get from the source map returned from node-sass will typically look like this:

../../../../../../../../../../D:/bourbon-example/scss/partial.scss

The bug happens when the input file and some included path are on different drives.

jasonsanjose added a commit that referenced this issue Feb 28, 2015
@jasonsanjose jasonsanjose added this to the v2.0 milestone Feb 28, 2015
@jasonsanjose
Copy link
Owner

Closing. Targeting v2.

@jasonsanjose
Copy link
Owner

See test build here #100 (comment) with path fixes for both libsass and ruby. Targeting for v2 release.

@jasonsanjose
Copy link
Owner

Re-opening since PR #100 hasn't been merged yet.

@jasonsanjose
Copy link
Owner

@tijtij there's a test build you can try here https://github.com/jasonsanjose/brackets-sass/releases/tag/2.0.1-105. If you have some time, please let me know if that fixes your problem.

@jasonsanjose jasonsanjose reopened this Mar 5, 2015
@tijtij
Copy link
Author

tijtij commented Mar 5, 2015

@jasonsanjose Works for me on Brackets 1.20-15697.

None of sources paths in *.css.map are using drive letters.

Thanks for the fix.

@tijtij tijtij closed this as completed Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants