Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to PIP_RUN_RETENTION_STRATEGY from mode #86

Merged
merged 7 commits into from
Oct 1, 2023
Merged

Switch to PIP_RUN_RETENTION_STRATEGY from mode #86

merged 7 commits into from
Oct 1, 2023

Conversation

jaraco
Copy link
Owner

@jaraco jaraco commented Oct 1, 2023

Closes #84

  • Replace PIP_RUN_MODE with PIP_RUN_RETENTION_STRATEGY, deprecating the former.
  • Rename modules for preferred 'retention strategy' naming.
  • Switch tests to use preferred 'retention strategy'
  • Don't bother covering fallback. It's coverage was proven in earlier commits.
  • For PIP_RUN_RETENTION_STRATEGY, renamed 'ephemeral' to 'destroy' (ref Improved sophistication of environment strategies #85). Update docs to reflect rename.
  • Add a news fragment.
  • Prefer UserWarning as any warning needs to be user visible.

@jaraco jaraco merged commit c71ce3b into main Oct 1, 2023
28 checks passed
@jaraco jaraco deleted the feature/84-retention-strategy branch October 1, 2023 16:27
@jaraco jaraco mentioned this pull request Oct 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider renaming PIP_RUN_MODE
1 participant
@jaraco