New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming PIP_RUN_MODE #84

Closed

jaraco opened this issue Sep 26, 2023 · 1 comment · Fixed by #86

Owner

jaraco commented Sep 26, 2023

In #82, I'm considering renaming the variable name "mode". The name is too general - doesn't convey its specific purpose.

Here are some alternatives I'm considering:

target: building on the name of the parameter used by pip
install target: incorporating the name of the command and parameter used by pip
env: inspired by the name of the "environment"
environment: full spelling of above
retention: captures the concept around persisting or not
strategy suffix: any of the above with "strategy" appended

I'm liking PIP_RUN_ENVIRONMENT_STRATEGY and PIP_RUN_RETENTION_STRATEGY best.

Owner Author

jaraco commented Oct 1, 2023

I'm planning to proceed with (PIP_RUN_) RETENTION_STRATEGY. It's a little verbose, but communicates the purpose best, IMO.

jaraco mentioned this issue

Switch to PIP_RUN_RETENTION_STRATEGY from mode #86

Merged

jaraco closed this as completed in #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment