Suppress SE_INNER_CLASS SpotBugs violations (jenkinsci#6121)

janfaracik · Dec 28, 2021 · f173994 · f173994
1 parent 1e96f8a
commit f173994
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/core/src/main/java/hudson/util/ProcessTree.java b/core/src/main/java/hudson/util/ProcessTree.java
@@ -394,6 +394,7 @@ public String call() throws IOException {
     /**
      * Serialized form of {@link OSProcess} is the PID and {@link ProcessTree}
      */
+    @SuppressFBWarnings(value = "SE_INNER_CLASS", justification = "Serializing the outer instance is intended")
     private final class SerializedProcess implements Serializable {
         private final int pid;
         private static final long serialVersionUID = 1L;
@@ -2177,6 +2178,7 @@ Object writeReplace() {
 
         private static final long serialVersionUID = 1L;
 
+        @SuppressFBWarnings(value = "SE_INNER_CLASS", justification = "Serializing the outer instance is intended")
         private class RemoteProcess extends OSProcess implements Serializable {
             private final IOSProcess proxy;
 

diff --git a/src/spotbugs/spotbugs-excludes.xml b/src/spotbugs/spotbugs-excludes.xml
@@ -383,13 +383,6 @@
         <Bug pattern="SE_BAD_FIELD"/>
         <Class name="hudson.scm.PollingResult"/>
       </And>
-      <And>
-        <Bug pattern="SE_INNER_CLASS"/>
-        <Or>
-          <Class name="hudson.util.ProcessTree$Remote$RemoteProcess"/>
-          <Class name="hudson.util.ProcessTree$SerializedProcess"/>
-        </Or>
-      </And>
       <And>
         <Bug pattern="STATIC_IV"/>
         <Or>