Fix scrolling with keyboard (jenkinsci#10054)

* Adapt keyboard.js to handle undefined as well as null * Adjust keyboard priority
janfaracik · Dec 14, 2024 · db744cc · db744cc
1 parent 7020e80
commit db744cc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/main/js/components/command-palette/index.js b/src/main/js/components/command-palette/index.js
@@ -32,6 +32,8 @@ function init() {
     searchResultsContainer,
     () => searchResults.querySelectorAll("a"),
     hoverClass,
+    () => {},
+    () => commandPalette.open,
   );
 
   // Events

diff --git a/src/main/js/util/keyboard.js b/src/main/js/util/keyboard.js
@@ -81,7 +81,7 @@ export default function makeKeyboardNavigable(
 }
 
 function scrollAndSelect(selectedItem, selectedClass, items) {
-  if (selectedItem !== null) {
+  if (selectedItem) {
     if (!isInViewport(selectedItem)) {
       selectedItem.scrollIntoView(false);
     }