Fix scrolling with keyboard #10054

timja · 2024-12-12T18:50:59Z

Testing done

Pressed up and down in system message text field, no console message
Scrolled the system configuration page, before fix didn't scroll, after fix scrolled.
Opened command palette, searched, used keyboard to navigate results
Closed command palette, can still scroll page with keyboard

Proposed changelog entries

Fix scrolling with keyboard

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

timja · 2024-12-12T21:34:35Z

src/main/js/util/keyboard.js

@@ -81,7 +81,7 @@ export default function makeKeyboardNavigable(
 }

 function scrollAndSelect(selectedItem, selectedClass, items) {
-  if (selectedItem !== null) {
+  if (selectedItem) {


not strictly needed now but its more resilient

timja · 2024-12-12T21:34:54Z

src/main/js/components/command-palette/index.js

@@ -32,6 +32,8 @@ function init() {
    searchResultsContainer,
    () => searchResults.querySelectorAll("a"),
    hoverClass,
+    () => {},
+    () => commandPalette.open,


only enables the keyboard navigation when the dialog is open which fixes it

timja · 2024-12-12T21:35:27Z

src/main/js/components/command-palette/index.js

@@ -32,6 +32,8 @@ function init() {
    searchResultsContainer,
    () => searchResults.querySelectorAll("a"),
    hoverClass,
+    () => {},


would have been nicer if this was being passed an object so as I didn't have to pass this as well

janfaracik

Big thanks :) LGTM

krisstern

Looks like this should fix the issue

timja · 2024-12-13T12:04:42Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

Adapt keyboard.js to handle undefined as well as null

7e43507

timja added the bug For changelog: Minor bug. Will be listed after features label Dec 12, 2024

timja marked this pull request as draft December 12, 2024 18:54

Adjust keyboard priority

fab3078

timja force-pushed the fix-null-check branch from 42ec5d5 to fab3078 Compare December 12, 2024 21:33

timja requested a review from janfaracik December 12, 2024 21:34

timja marked this pull request as ready for review December 12, 2024 21:34

Merge branch 'master' into fix-null-check

ed89078

timja commented Dec 12, 2024

View reviewed changes

timja requested a review from a team December 12, 2024 21:35

timja changed the title ~~Adapt keyboard.js to handle undefined as well as null~~ Fix scrolling with keyboard Dec 12, 2024

timja added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Dec 12, 2024

janfaracik approved these changes Dec 13, 2024

View reviewed changes

krisstern approved these changes Dec 13, 2024

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Dec 13, 2024

NotMyFault approved these changes Dec 14, 2024

View reviewed changes

timja merged commit db744cc into jenkinsci:master Dec 14, 2024
16 checks passed

timja deleted the fix-null-check branch December 14, 2024 11:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix scrolling with keyboard #10054

Fix scrolling with keyboard #10054

timja commented Dec 12, 2024 •

edited

Loading

Submitter checklist

Maintainer checklist

timja Dec 12, 2024

timja Dec 12, 2024

timja Dec 12, 2024

janfaracik left a comment

krisstern left a comment

timja commented Dec 13, 2024

Fix scrolling with keyboard #10054

Fix scrolling with keyboard #10054

Conversation

timja commented Dec 12, 2024 • edited Loading

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

timja Dec 12, 2024

Choose a reason for hiding this comment

timja Dec 12, 2024

Choose a reason for hiding this comment

timja Dec 12, 2024

Choose a reason for hiding this comment

janfaracik left a comment

Choose a reason for hiding this comment

krisstern left a comment

Choose a reason for hiding this comment

timja commented Dec 13, 2024

timja commented Dec 12, 2024 •

edited

Loading