Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Upload Part - Copy #443

Merged
merged 7 commits into from
Apr 3, 2021
Merged

Conversation

juliangruber
Copy link
Contributor

@juliangruber juliangruber commented Apr 17, 2019

This partially implements Upload Part - Copy:

  • Upload part by copy
  • Cross bucket
  • x-amz-copy-source-range
  • x-amz-copy-source-if-match
  • x-amz-copy-source-if-none-match
  • x-amz-copy-source-if-unmodified-since
  • x-amz-copy-source-if-modified-since

This is as much as I personally need from this function.

@juliangruber juliangruber marked this pull request as ready for review April 17, 2019 13:01
@kherock
Copy link
Collaborator

kherock commented Apr 18, 2019

Thanks for the quick PR! Let me know when you want me to review this.

@juliangruber
Copy link
Contributor Author

I don't need this function any more so I'll let you decide what to do with this :)

@jeffbski-rga
Copy link
Contributor

This is still good functionality. I currently need it in my project.

Base automatically changed from master to main February 12, 2021 14:09
@kherock kherock force-pushed the upload-part-copy branch from 2cf6483 to f276278 Compare March 5, 2021 00:35
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #443 (f31bb77) into main (eaa43c3) will increase coverage by 0.06%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
+ Coverage   89.16%   89.22%   +0.06%     
==========================================
  Files          20       20              
  Lines        1375     1402      +27     
==========================================
+ Hits         1226     1251      +25     
- Misses        149      151       +2     
Impacted Files Coverage Δ
lib/controllers/object.js 90.11% <89.65%> (-0.06%) ⬇️
lib/routes.js 78.75% <100.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa43c3...f31bb77. Read the comment docs.

@kherock kherock force-pushed the upload-part-copy branch 2 times, most recently from 0b751f2 to 985379b Compare March 5, 2021 01:01
@kherock kherock force-pushed the upload-part-copy branch from 985379b to 7ad3c78 Compare March 6, 2021 16:22
@kherock kherock force-pushed the upload-part-copy branch from d625728 to f31bb77 Compare April 3, 2021 18:02
Copy link
Collaborator

@kherock kherock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've improved the tests for this a bit and added support for copy ranges. the x-amz-copy-source-if-* headers are still unimplemented but should be straightforward to add later.

@kherock kherock merged commit cf23e9d into jamhall:main Apr 3, 2021
@juliangruber juliangruber deleted the upload-part-copy branch April 4, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants