-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Upload Part - Copy #443
Conversation
Thanks for the quick PR! Let me know when you want me to review this. |
I don't need this function any more so I'll let you decide what to do with this :) |
This is still good functionality. I currently need it in my project. |
2cf6483
to
f276278
Compare
Codecov Report
@@ Coverage Diff @@
## main #443 +/- ##
==========================================
+ Coverage 89.16% 89.22% +0.06%
==========================================
Files 20 20
Lines 1375 1402 +27
==========================================
+ Hits 1226 1251 +25
- Misses 149 151 +2
Continue to review full report at Codecov.
|
0b751f2
to
985379b
Compare
985379b
to
7ad3c78
Compare
d625728
to
f31bb77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've improved the tests for this a bit and added support for copy ranges. the x-amz-copy-source-if-*
headers are still unimplemented but should be straightforward to add later.
This partially implements Upload Part - Copy:
x-amz-copy-source-range
x-amz-copy-source-if-match
x-amz-copy-source-if-none-match
x-amz-copy-source-if-unmodified-since
x-amz-copy-source-if-modified-since
This is as much as I personally need from this function.