Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Upload Part - Copy #436

Closed
juliangruber opened this issue Apr 12, 2019 · 4 comments
Closed

Implement Upload Part - Copy #436

juliangruber opened this issue Apr 12, 2019 · 4 comments
Labels
feature request

Comments

@juliangruber
Copy link
Contributor

The response body of s3.uploadPartCopy should contain { CopyPartResult: { ETag, ... } }, however I'm just receiving { CopyPartResult: {} }.

See https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#uploadPartCopy-property.
@kherock
Copy link
Collaborator

kherock commented Apr 14, 2019

Upload Part - Copy isn't actually supported by S3rver, but I can at least have that stubbed with 501 error for the next patch release so that the behavior isn't as confusing.

@kherock kherock changed the title CopyPartResult empty Implement Upload Part - Copy Apr 14, 2019
@kherock
Copy link
Collaborator

kherock commented Apr 14, 2019

It doesn't look too difficult to add though, I'll try to address this for v3.1 (PRs are welcome)!

@kherock kherock mentioned this issue Apr 17, 2019
Merged
@juliangruber
Copy link
Contributor Author

juliangruber commented Apr 17, 2019 •
edited
Loading

PR: #443

@fishcharlie fishcharlie mentioned this issue Feb 14, 2021
Open
@kherock
Copy link
Collaborator

kherock commented May 15, 2021

The support that was implemented by #443 has been merged into main and will be available in the first 4.x release.

@kherock kherock closed this as completed May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juliangruber @kherock