[kafka-consumer] Ingester should use topic name from actual Kafka consumer instead of configuration #4593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue jaegertracing#4592 Summary of changes: When handling messages use the topic name from PartitionConsumer that reflects the topic where message is consumed from. Signed-off-by: Alex Bublichenko <[email protected]>
yurishkuro
reviewed
Jul 19, 2023
yurishkuro
reviewed
Jul 19, 2023
abliqo
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4593 +/- ##
=======================================
Coverage 97.05% 97.05%
=======================================
Files 302 302
Lines 17853 17852 -1
=======================================
Hits 17327 17327
+ Misses 422 421 -1
Partials 104 104
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
yurishkuro
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #4592
Short description of the changes
When handling messages use the topic name from PartitionConsumer that reflects the topic where message is consumed from.