Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Consumer metrics should have a tag with topic name #4777

Closed
abliqo opened this issue Sep 26, 2023 · 1 comment · Fixed by #4778
Closed

[Bug]: Consumer metrics should have a tag with topic name #4777

abliqo opened this issue Sep 26, 2023 · 1 comment · Fixed by #4778
Labels

Comments

@abliqo
Copy link
Contributor

abliqo commented Sep 26, 2023

What happened?

The recent change 4593 updated the consumer code of the ingester to support ingestion from multiple Kafka topics when sarama consumer is created in custom way with multiple topics. However, the metrics lack the tag with topic name.

Steps to reproduce

  1. Ingest from multiple Kafka topics with sarama consumer created in custom way.
  2. Check the metric with name name:sarama-consumer.messages - it does not have information about the topic.

Expected behavior

All consumer metrics should have a tag with topic name.

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

@abliqo abliqo added the bug label Sep 26, 2023
@abliqo
Copy link
Contributor Author

abliqo commented Sep 26, 2023

I will make a change.

@abliqo abliqo changed the title [Bug]: Consumer metrics do not have a tag with topic name [Bug]: Consumer metrics should have a tag with topic name Sep 26, 2023
abliqo added a commit to abliqo/jaeger that referenced this issue Sep 26, 2023
Resolves jaegertracing#4777

Add tag with topic name to Kafka consumer metrics.

Signed-off-by: Alex Bublichenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant