Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clean-up after #3640 #3653

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro requested a review from a team as a code owner May 4, 2022 05:14
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #3653 (ac45530) into main (99ec00f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3653      +/-   ##
==========================================
+ Coverage   96.50%   96.52%   +0.01%     
==========================================
  Files         265      265              
  Lines       15581    15581              
==========================================
+ Hits        15036    15039       +3     
+ Misses        455      454       -1     
+ Partials       90       88       -2     
Impacted Files Coverage Δ
cmd/collector/app/server/zipkin.go 68.29% <0.00%> (-2.44%) ⬇️
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.21% <0.00%> (+0.70%) ⬆️
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ec00f...ac45530. Read the comment docs.

@yurishkuro yurishkuro merged commit 754880c into jaegertracing:main May 4, 2022
@yurishkuro yurishkuro deleted the fix-3640 branch May 4, 2022 05:38
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant