-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add streamingSpanWriterPlugin #3640
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3640 +/- ##
==========================================
+ Coverage 96.40% 96.50% +0.10%
==========================================
Files 264 265 +1
Lines 15509 15581 +72
==========================================
+ Hits 14951 15037 +86
+ Misses 468 455 -13
+ Partials 90 89 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I feel like I am missing something. It's not clear to me why we need a separate "streaming client" writer, could we not do it from the existing client?
But more importantly, I think the overall approach we had taken when we extended the plugin contract with "archive" storage was to add Capabilities field that tells the client if the plugin implementation supports additional interfaces. So I am surprised that you don't have any changed to the Factory files.
Lastly, I would like to have integration tests to exercise the new functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall, I kicked off the tests
@yurishkuro Hi yuri, all the issues you commented have been resolved. |
Signed-off-by: vuuihc <[email protected]>
I will try to do a final review tomorrow |
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: vuuihc <[email protected]> Signed-off-by: Albert Teoh <[email protected]>
Signed-off-by: Albert Teoh <[email protected]>
Signed-off-by: vuuihc [email protected]
Which problem is this PR solving?
Resolves #3636
Short description of the changes
add streamingSpanWriterPlugin to improve the write performance of grpc plugin.