Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI Option for gRPC Max Receive Message Size #3214

Merged
merged 6 commits into from
Aug 17, 2021
Merged

Add CLI Option for gRPC Max Receive Message Size #3214

merged 6 commits into from
Aug 17, 2021

Commits on Aug 16, 2021

  1. Add CLI Option for gRPC Max Receive Message Size 

    Added a new CLI option for the gRPC Collector to override the default
max receive message size which is normally 4MB since some users of
Jaeger may want to record Spans which exceed the default max size.

Signed-off-by: Justin Stauffer <[email protected]>
    @js8080
    js8080 committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    226e3ae View commit details
    Browse the repository at this point in the history

  2. Changed gRPC Max Receive Message Length Option Name 

    Changed collector.grpc-max-receive-message-length to
collector.grpc.max-receive-message-length for consistency.

Signed-off-by: Justin Stauffer <[email protected]>
    @js8080
    js8080 committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    ac15861 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Change New gRPC Max Message Size Option Name 

    Changes new option from `collector.grpc.max-receive-message-length` to
`collector.grpc-server.max-message-size` as suggested during review.

Signed-off-by: Justin Stauffer <[email protected]>
    @js8080
    js8080 committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    b2f98ec View commit details
    Browse the repository at this point in the history

  2. Attempting to add Test Coverage for gRPC Server with TLS 

    Added a test that hopefully adds necessary code coverage for the
gRPC collector code around the TLS options.

Signed-off-by: Justin Stauffer <[email protected]>
    @js8080
    js8080 committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    13e8ea0 View commit details
    Browse the repository at this point in the history

  3. Adjust Test for gRPC Server Start with TLS 

    Changed my previous new test to only test the GRPC Server Startup.

Signed-off-by: Justin Stauffer <[email protected]>
    @js8080
    js8080 committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    802fd9f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into jstauffer/add-cli-option-for-grpc-max-recv… 

    …-msg-size
    @yurishkuro
    yurishkuro authored Aug 17, 2021
    Configuration menu
    Copy the full SHA
    ca68f5a View commit details
    Browse the repository at this point in the history