Add CLI Option for gRPC Max Receive Message Size #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new CLI option for the gRPC Collector to override the default max receive message size which is normally 4MB since some users of Jaeger may want to record Spans which exceed the default max size. Signed-off-by: Justin Stauffer <[email protected]>
Changed collector.grpc-max-receive-message-length to collector.grpc.max-receive-message-length for consistency. Signed-off-by: Justin Stauffer <[email protected]>
Changes new option from `collector.grpc.max-receive-message-length` to `collector.grpc-server.max-message-size` as suggested during review. Signed-off-by: Justin Stauffer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3214 +/- ##
==========================================
+ Coverage 95.90% 95.95% +0.04%
==========================================
Files 242 242
Lines 14786 14794 +8
==========================================
+ Hits 14181 14195 +14
+ Misses 525 518 -7
- Partials 80 81 +1
Continue to review full report at Codecov.
|
Added a test that hopefully adds necessary code coverage for the gRPC collector code around the TLS options. Signed-off-by: Justin Stauffer <[email protected]>
Changed my previous new test to only test the GRPC Server Startup. Signed-off-by: Justin Stauffer <[email protected]>
|
@Ashmita152 I made this new PR as suggested. @yurishkuro this includes the changes you suggested in my old, closed PR. I also added another very basic test as I was getting errors from lack of code coverage. I'm not a Go expert so I'm not quite sure how that test can be improved though I don't doubt it could be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #3210
Short description of the changes
Added a new CLI option for the gRPC Collector to override the default
max receive message size which is normally 4MB since some users of
Jaeger may want to record Spans which exceed the default max size.
Signed-off-by: Justin Stauffer [email protected]