Add context to dependencies endpoint #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoave23
force-pushed
the
Propagate-auth-token-in-dependencies-endpoint
branch
from
771b6c5
to
f322f40
Compare
yoave23
changed the title
/dependencies endpoint
yurishkuro
reviewed
Aug 30, 2020
| @@ -213,7 +213,7 @@ var _escData = map[string]*_escFile{ | |||
| name: "index.html", | |||
There was a problem hiding this comment.
please exclude this file from the PR, it's not related
| indices := getIndices(s.indexPrefix, endTs, lookback) | ||
| searchResult, err := s.client.Search(indices...). | ||
| Size(10000). // the default elasticsearch allowed limit | ||
| Query(buildTSQuery(endTs, lookback)). | ||
| IgnoreUnavailable(true). | ||
| Do(s.ctx) | ||
| Do(ctx) |
There was a problem hiding this comment.
Good catch. Can we delete the field s.ctx altogether? I think it was implemented as anti-pattern.
| @@ -213,7 +213,7 @@ var _escData = map[string]*_escFile{ | |||
| name: ".nocover", | |||
yoave23
force-pushed
the
Propagate-auth-token-in-dependencies-endpoint
branch
from
f322f40
to
86dc478
Compare
Signed-off-by: Yoav Eyal <[email protected]>
yoave23
force-pushed
the
Propagate-auth-token-in-dependencies-endpoint
branch
from
86dc478
to
614701d
Compare
Signed-off-by: Yoav Eyal <[email protected]>
Signed-off-by: yoave23 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2434 +/- ##
=======================================
Coverage 95.57% 95.58%
=======================================
Files 208 208
Lines 10682 10681 -1
=======================================
Hits 10209 10209
+ Misses 400 399 -1
Partials 73 73
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
/dependenciesendpointShort description of the changes
context.Contextparam to theGetDependenciesinterface and implement accordingly