-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jaeger query doesn't propagate auth token on dependency endpoint #2369
Labels
Comments
ghost
added
the
needs-triage
label
Aug 3, 2020
@yoave23 Thanks for reporting this - would you be interested in submitting a PR? |
@objectiser sure, on it |
@objectiser it seems like we need to change the |
@yoave23 Yes that is the right approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Jaeger query doesn't propagate auth token on the
/dependencies
endpoint. Works fine others.To Reproduce
Steps to reproduce the behavior:
QUERY_BEARER_TOKEN_PROPAGATION=true
/dependencies?endTs=?????????&lookback=???????
with an authorization tokenExpected behavior
The dependency endpoint should propagate the auth token the same way it does on other endpoints (/operations, /traces, etc.)
Version (please complete the following information):
Additional context
We're using ES as storage although it seems that it affects all storage types
looks like the issue (for ES storage) is located here:
plugin/storage/es/dependencystore/storage.go:84
where it uses theDependencyStore
's context (Background
context) instead of the original oneThe text was updated successfully, but these errors were encountered: