remove ErrorBusy, it essentially duplicates SpansDropped #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstyan
requested review from
black-adder,
jpkrohling,
pavolloffay,
vprithvi and
yurishkuro
as code owners
objectiser
suggested changes
Nov 23, 2018
cmd/collector/app/span_processor.go
Outdated
| @@ -141,8 +140,6 @@ func (sp *spanProcessor) enqueueSpan(span *model.Span, originalFormat string) bo | |||
| span: span, | |||
| } | |||
| addedToQueue := sp.queue.Produce(item) | |||
There was a problem hiding this comment.
The addedToQueue is no longer required, so could just have return sp.queue.Produce(item)
Signed-off-by: Callum Styan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1091 +/- ##
======================================
Coverage 100% 100%
======================================
Files 162 162
Lines 7263 7259 -4
======================================
- Hits 7263 7259 -4
Continue to review full report at Codecov.
|
|
@objectiser sorry for the delay. Removed |
objectiser
approved these changes
Jan 23, 2019
|
@yurishkuro Are you ok with this duplicate metric being removed? If so, we just need to list it as a breaking change for next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1065
Signed-off-by: Callum Styan [email protected]
Which problem is this PR solving?
Removes ErrorBusy. Having not looked at the code before, I assume that if a span can't be added to the queue it is just dropped (hence SpansDropped). If that's the case, then ErrorBusy would duplicate SpansDropped but the name provides less context.
Short description of the changes
Removes ErrorBusy.