remove ErrorBusy, it essentially duplicates SpansDropped

Signed-off-by: Callum Styan <[email protected]>

cmd/collector/app/metrics.go

@@ -40,8 +40,6 @@ type SpanProcessorMetrics struct {
 	BatchSize metrics.Gauge // size of span batch
 	// QueueLength measures the size of the internal span queue
 	QueueLength metrics.Gauge
-	// ErrorBusy counts number of return ErrServerBusy
-	ErrorBusy metrics.Counter
 	// SavedOkBySvc contains span and trace counts by service
 	SavedOkBySvc  metricsBySvc  // spans actually saved
 	SavedErrBySvc metricsBySvc  // spans failed to save
@@ -87,7 +85,6 @@ func NewSpanProcessorMetrics(serviceMetrics metrics.Factory, hostMetrics metrics
 		SpansDropped:   hostMetrics.Counter("spans.dropped", nil),
 		BatchSize:      hostMetrics.Gauge("batch-size", nil),
 		QueueLength:    hostMetrics.Gauge("queue-length", nil),
-		ErrorBusy:      hostMetrics.Counter("error.busy", nil),
 		SavedOkBySvc:   newMetricsBySvc(serviceMetrics.Namespace("", map[string]string{"result": "ok"}), "saved-by-svc"),
 		SavedErrBySvc:  newMetricsBySvc(serviceMetrics.Namespace("", map[string]string{"result": "err"}), "saved-by-svc"),
 		spanCounts:     spanCounts,

cmd/collector/app/span_processor.go

@@ -17,7 +17,6 @@ package app
 import (
 	"time"
 
-	"github.com/uber/tchannel-go"
 	"go.uber.org/zap"
 
 	"github.com/jaegertracing/jaeger/cmd/collector/app/sanitizer"
@@ -141,8 +140,6 @@ func (sp *spanProcessor) enqueueSpan(span *model.Span, originalFormat string) bo
 		span:       span,
 	}
 	addedToQueue := sp.queue.Produce(item)
-	if !addedToQueue {
-		sp.metrics.ErrorBusy.Inc(1)
-	}
+
 	return addedToQueue
 }