This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Treat gauge.update() parameter as new value, not delta #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In InMemoryMetricsFactory, upon updating the gauge, the argument should be considered as the new value and not a variation to the previous one. Signed-off-by: Mehrez Douaihy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
=========================================
Coverage 88.24% 88.24%
Complexity 488 488
=========================================
Files 63 63
Lines 1846 1846
Branches 240 240
=========================================
Hits 1629 1629
Misses 139 139
Partials 78 78
Continue to review full report at Codecov.
|
yurishkuro
changed the title
yurishkuro
approved these changes
Jun 21, 2018
yurishkuro
changed the title
|
Thank you for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
InMemoryMetricsFactory gauge wrongly update its value.
Resolves #459.
Description of the change
In InMemoryMetricsFactory, upon updating the gauge, the argument
should be considered as the new value and not a variation to
the previous one.
Signed-off-by: Mehrez Douaihy [email protected]