Treat gauge.update() parameter as new value, not delta (#463)

In InMemoryMetricsFactory, upon updating the gauge, the argument should be considered as the new value and not a variation to the previous one. Resolves #459. Signed-off-by: Mehrez Douaihy <[email protected]>
jaegertracing · Jun 21, 2018 · e76b6a9 · e76b6a9
1 parent 331bc04
commit e76b6a9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/jaeger-core/src/main/java/io/jaegertracing/metrics/InMemoryMetricsFactory.java b/jaeger-core/src/main/java/io/jaegertracing/metrics/InMemoryMetricsFactory.java
@@ -62,7 +62,7 @@ public Gauge createGauge(final String name, final Map<String, String> tags) {
     return new Gauge() {
       @Override
       public void update(long amount) {
-        value.addAndGet(amount);
+        value.getAndSet(amount);
       }
     };
   }

diff --git a/jaeger-core/src/test/java/io/jaegertracing/metrics/InMemoryMetricsFactoryTest.java b/jaeger-core/src/test/java/io/jaegertracing/metrics/InMemoryMetricsFactoryTest.java
@@ -85,16 +85,18 @@ public void metricNameIsUsedForGauge() {
   }
 
   @Test
-  public void gaugeValueIsIncreased() {
+  public void gaugeValueIsUpdated() {
     Map<String, String> tags = Collections.singletonMap("foo", "bar");
 
     InMemoryMetricsFactory inMemoryMetricsFactory = new InMemoryMetricsFactory();
     Gauge gauge = inMemoryMetricsFactory.createGauge("thegauge", tags);
     assertEquals(0, inMemoryMetricsFactory.getGauge("thegauge", tags));
 
     gauge.update(1);
-
     assertEquals(1, inMemoryMetricsFactory.getGauge("thegauge", tags));
+
+    gauge.update(2);
+    assertEquals(2, inMemoryMetricsFactory.getGauge("thegauge", tags));
   }
 
   @Test