This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
fix deploy stage on travis #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
=========================================
Coverage 82.81% 82.81%
Complexity 490 490
=========================================
Files 66 66
Lines 2019 2019
Branches 247 247
=========================================
Hits 1672 1672
Misses 265 265
Partials 82 82Continue to review full report at Codecov.
|
The previous condition was always false, the deploy stage wasn't executed. Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
force-pushed
the
fix-travis-deploy-condition
branch
from
863223a
to
e4f9948
Compare
ghost
assigned
pavolloffay
changed the title
|
I think wi will find out if it works once it's merged. |
jpkrohling
approved these changes
May 17, 2018
|
let's merge and hope 🙏 |
|
It looks promising https://travis-ci.org/jaegertracing/jaeger-client-java/builds/380130241 deploy stage is there |
|
There was a failure for deploy to the hub:
I will submit the following PR to fix it. |
|
Here is a comparison of deploy to maven
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#389 changed travis configuration to use stages. There is a condition which enables
deploystage https://github.com/jaegertracing/jaeger-client-java/pull/389/files#diff-354f30a63fb0907d4ad57269548329e3R36. However it doesn't seem to work see https://travis-ci.org/jaegertracing/jaeger-client-java/builds/379736616deployis missingSigned-off-by: Pavol Loffay [email protected]