Use travis stages to simplify config

[pavolloffay]

• uses more declarative approach
• split deployment from tests
• should fail if the deploy fails - which does not hold for the current config - for example publish here https://travis-ci.org/jaegertracing/jaeger-client-java/jobs/365086226#L1333 failed and build is green

Docs for if statement: https://docs.travis-ci.com/user/conditional-builds-stages-jobs/

Signed-off-by: Pavol Loffay [email protected]

[codecov]

Codecov Report

Merging #389 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #389   +/-   ##
=========================================
  Coverage     84.25%   84.25%           
  Complexity      500      500           
=========================================
  Files            66       66           
  Lines          2033     2033           
  Branches        247      247           
=========================================
  Hits           1713     1713           
  Misses          239      239           
  Partials         81       81

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d12b7...6883003. Read the comment docs.

[yurishkuro]

we should probably rename this script to publish-crossdock.sh

[yurishkuro]

not sure I follow this setup. The build shows only two steps now, both from the test stage. Where can we see the logs & status from the deploy stage?

[pavolloffay]

It will appear once it condition in if is true - not a PR request

[yurishkuro]

Is the indentation correct here? I was expecting something like

  - stage: test
    - env:
      script: 
    - env:
      script: 

[pavolloffay]

yes it is correct

[yurishkuro]

why is it correct though? It seems order dependent. Can we add stage: test as the first line of the second group, to make it more obvious?

[pavolloffay]

can try, I have copied it from this repo https://github.com/opentracing-contrib/java-spring-cloud/blob/master/.travis.yml#L25 it uses even more stages

[yurishkuro]

it looks like Travis explicitly allows that (i.e. the order matters and stage name is inherited from the previous item). Feels like a bad practice to me.

[pavolloffay]

This works (done in the last commit):

jobs:
  include:
    - stage: test
      env: [ NAME=unit-test ]
      script: make test-travis && ./gradlew codeCoverageReport && bash <(curl -s https://codecov.io/bash)

    - stage: test
      env: [ NAME=crossdock ]
      script: make crossdock-fresh

    - stage: deploy
      env: [ NAME=deploy-to-maven ]
      script: ./gradlew upload

    - stage: deploy
      env: [ NAME=deploy-to-dockerhub ]
      script: ./travis/publish-crossdock.sh

[pavolloffay]

@yurishkuro PR rebased and updated